[GitHub] [incubator-kvrocks] git-hulk commented on a diff in pull request #1475: Refine functions and add parsing test to set and zset

["git-hulk (via GitHub)" <gi...@apache.org>]

git-hulk commented on code in PR #1475:
URL: https://github.com/apache/incubator-kvrocks/pull/1475#discussion_r1206399019


##########
src/commands/cmd_zset.cc:
##########
@@ -223,7 +223,9 @@ class CommandZPop : public Commander {
   explicit CommandZPop(bool min) : min_(min) {}
 
   Status Parse(const std::vector<std::string> &args) override {
-    if (args.size() > 2) {
+    if (args.size() > 3) {
+      return {Status::RedisParseErr, errWrongNumOfArguments};
+    } else if (args.size() == 3) {

Review Comment:
   ```suggestion
       }
   
       if (args.size() == 3) {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org