You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by András Piros via Review Board <no...@reviews.apache.org> on 2018/11/15 11:47:36 UTC
Review Request 69348: OOZIE-3381 [coordinator] Enhance logging of
CoordElFunctions
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69348/
-----------------------------------------------------------
Review request for oozie and Kinga Marton.
Repository: oozie-git
Description
-------
OOZIE-3381 [coordinator] Enhance logging of CoordElFunctions
Diffs
-----
core/src/main/java/org/apache/oozie/command/XCommand.java a80444e14134ec4234e6edfef0888cf1e76566df
core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java 10f4f0d8d14fbb8d60a2d09a45b8f3b3b089f461
Diff: https://reviews.apache.org/r/69348/diff/1/
Testing
-------
`TestCoordELFunctions`
Thanks,
András Piros
Re: Review Request 69348: OOZIE-3381 [coordinator] Enhance logging of
CoordElFunctions
Posted by Kinga Marton via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69348/#review210789
-----------------------------------------------------------
Ship it!
Ship It!
- Kinga Marton
On Nov. 20, 2018, 10:54 a.m., András Piros wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69348/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2018, 10:54 a.m.)
>
>
> Review request for oozie and Kinga Marton.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> OOZIE-3381 [coordinator] Enhance logging of CoordElFunctions
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/command/XCommand.java a80444e14134ec4234e6edfef0888cf1e76566df
> core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java 10f4f0d8d14fbb8d60a2d09a45b8f3b3b089f461
> core/src/test/java/org/apache/oozie/command/coord/CoordELExtensions.java 796d19cfc9cbd03211746f9b94d0f67371249c7e
> core/src/test/java/org/apache/oozie/coord/TestOozieTimeUnitConverter.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/69348/diff/2/
>
>
> Testing
> -------
>
> `TestCoordELFunctions`
>
>
> Thanks,
>
> András Piros
>
>
Re: Review Request 69348: OOZIE-3381 [coordinator] Enhance logging of
CoordElFunctions
Posted by András Piros via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69348/
-----------------------------------------------------------
(Updated Nov. 20, 2018, 10:54 a.m.)
Review request for oozie and Kinga Marton.
Changes
-------
Update based on review comments.
Repository: oozie-git
Description
-------
OOZIE-3381 [coordinator] Enhance logging of CoordElFunctions
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/command/XCommand.java a80444e14134ec4234e6edfef0888cf1e76566df
core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java 10f4f0d8d14fbb8d60a2d09a45b8f3b3b089f461
core/src/test/java/org/apache/oozie/command/coord/CoordELExtensions.java 796d19cfc9cbd03211746f9b94d0f67371249c7e
core/src/test/java/org/apache/oozie/coord/TestOozieTimeUnitConverter.java PRE-CREATION
Diff: https://reviews.apache.org/r/69348/diff/2/
Changes: https://reviews.apache.org/r/69348/diff/1-2/
Testing
-------
`TestCoordELFunctions`
Thanks,
András Piros
Re: Review Request 69348: OOZIE-3381 [coordinator] Enhance logging of
CoordElFunctions
Posted by Kinga Marton via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69348/#review210567
-----------------------------------------------------------
core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java
Lines 1587 (patched)
<https://reviews.apache.org/r/69348/#comment295280>
Services.getConf() is depricated. Can you please change it to ConfigurationService.getBoolean()?
core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java
Lines 1644 (patched)
<https://reviews.apache.org/r/69348/#comment295267>
I know this is an old code, but why do we need an array here? Everywhere is used only the first element from it. Can't we change it to use a simple int instead of an array of ints (maybe in a follow up issue)?
core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java
Lines 1672 (patched)
<https://reviews.apache.org/r/69348/#comment295283>
I think that this is unnecessary here because instCount is already instantiated (see line 1644)
core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java
Lines 1781 (patched)
<https://reviews.apache.org/r/69348/#comment295278>
Please remove comment
core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java
Lines 1784 (patched)
<https://reviews.apache.org/r/69348/#comment295279>
Please remove comment
core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java
Lines 1883 (patched)
<https://reviews.apache.org/r/69348/#comment295268>
Can you please add some Unit tests for this method?
- Kinga Marton
On Nov. 15, 2018, 11:47 a.m., András Piros wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69348/
> -----------------------------------------------------------
>
> (Updated Nov. 15, 2018, 11:47 a.m.)
>
>
> Review request for oozie and Kinga Marton.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> OOZIE-3381 [coordinator] Enhance logging of CoordElFunctions
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/command/XCommand.java a80444e14134ec4234e6edfef0888cf1e76566df
> core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java 10f4f0d8d14fbb8d60a2d09a45b8f3b3b089f461
>
>
> Diff: https://reviews.apache.org/r/69348/diff/1/
>
>
> Testing
> -------
>
> `TestCoordELFunctions`
>
>
> Thanks,
>
> András Piros
>
>