You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2017/06/22 18:58:38 UTC
[kudu-CR] [mini {master,tablet server}] micro clean-up
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7265
Change subject: [mini_{master,tablet_server}] micro clean-up
......................................................................
[mini_{master,tablet_server}] micro clean-up
A micro clean-up on mini_master and mini_tablet_server:
* remove unused FsManager member from MiniTabletServer
* use std::unique_ptr instead of gscoped_ptr
* get rid of started_ member
* removed redundant CHECK() statements
* other unsorted micro-updates
Change-Id: I9fc34b6f8ff94098551e567f4aefa4e92a907f53
---
M src/kudu/integration-tests/master_cert_authority-itest.cc
M src/kudu/integration-tests/mini_cluster.cc
M src/kudu/master/mini_master.cc
M src/kudu/master/mini_master.h
M src/kudu/tserver/mini_tablet_server.cc
M src/kudu/tserver/mini_tablet_server.h
6 files changed, 42 insertions(+), 67 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/65/7265/1
--
To view, visit http://gerrit.cloudera.org:8080/7265
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9fc34b6f8ff94098551e567f4aefa4e92a907f53
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [mini {master,tablet server}] micro clean-up
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [mini_{master,tablet_server}] micro clean-up
......................................................................
Patch Set 1: Verified+1
Unrelated flake in MultiThreadedHybridClockTabletTest/5.UpdateNoMergeCompaction
--
To view, visit http://gerrit.cloudera.org:8080/7265
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9fc34b6f8ff94098551e567f4aefa4e92a907f53
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [mini {master,tablet server}] micro clean-up
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [mini_{master,tablet_server}] micro clean-up
......................................................................
Patch Set 1:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/7265/1/src/kudu/master/mini_master.cc
File src/kudu/master/mini_master.cc:
Line 36: using std::vector;
> Nit: out of order.
Done
Line 79: master_.reset();
> Nit: may as well move this into the if block.
Done
http://gerrit.cloudera.org:8080/#/c/7265/1/src/kudu/master/mini_master.h
File src/kudu/master/mini_master.h:
Line 64: bool is_started() const { return master_.get() != nullptr; }
> warning: redundant get() call on smart pointer [google-readability-redundan
Done
Line 80: Status StartOnPorts(uint16_t rpc_port, uint16_t web_port,
> warning: function 'kudu::master::MiniMaster::StartOnPorts' has a definition
Done
http://gerrit.cloudera.org:8080/#/c/7265/1/src/kudu/tserver/mini_tablet_server.h
File src/kudu/tserver/mini_tablet_server.h:
Line 94: bool is_started() const { return server_.get() != nullptr; }
> warning: redundant get() call on smart pointer [google-readability-redundan
Done
--
To view, visit http://gerrit.cloudera.org:8080/7265
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9fc34b6f8ff94098551e567f4aefa4e92a907f53
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [mini {master,tablet server}] micro clean-up
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has uploaded a new patch set (#2).
Change subject: [mini_{master,tablet_server}] micro clean-up
......................................................................
[mini_{master,tablet_server}] micro clean-up
A micro clean-up on mini_master and mini_tablet_server:
* remove unused FsManager member from MiniTabletServer
* use std::unique_ptr instead of gscoped_ptr
* get rid of started_ member
* removed redundant CHECK() statements
* other unsorted micro-updates
Change-Id: I9fc34b6f8ff94098551e567f4aefa4e92a907f53
---
M src/kudu/integration-tests/master_cert_authority-itest.cc
M src/kudu/integration-tests/mini_cluster.cc
M src/kudu/master/mini_master.cc
M src/kudu/master/mini_master.h
M src/kudu/tserver/mini_tablet_server.cc
M src/kudu/tserver/mini_tablet_server.h
6 files changed, 47 insertions(+), 72 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/65/7265/2
--
To view, visit http://gerrit.cloudera.org:8080/7265
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9fc34b6f8ff94098551e567f4aefa4e92a907f53
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [mini {master,tablet server}] micro clean-up
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [mini_{master,tablet_server}] micro clean-up
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7265
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9fc34b6f8ff94098551e567f4aefa4e92a907f53
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [mini {master,tablet server}] micro clean-up
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged.
Change subject: [mini_{master,tablet_server}] micro clean-up
......................................................................
[mini_{master,tablet_server}] micro clean-up
A micro clean-up on mini_master and mini_tablet_server:
* remove unused FsManager member from MiniTabletServer
* use std::unique_ptr instead of gscoped_ptr
* get rid of started_ member
* removed redundant CHECK() statements
* other unsorted micro-updates
Change-Id: I9fc34b6f8ff94098551e567f4aefa4e92a907f53
Reviewed-on: http://gerrit.cloudera.org:8080/7265
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/integration-tests/master_cert_authority-itest.cc
M src/kudu/integration-tests/mini_cluster.cc
M src/kudu/master/mini_master.cc
M src/kudu/master/mini_master.h
M src/kudu/tserver/mini_tablet_server.cc
M src/kudu/tserver/mini_tablet_server.h
6 files changed, 47 insertions(+), 72 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/7265
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9fc34b6f8ff94098551e567f4aefa4e92a907f53
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [mini {master,tablet server}] micro clean-up
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [mini_{master,tablet_server}] micro clean-up
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7265/1/src/kudu/master/mini_master.cc
File src/kudu/master/mini_master.cc:
Line 36: using std::vector;
Nit: out of order.
Line 79: master_.reset();
Nit: may as well move this into the if block.
--
To view, visit http://gerrit.cloudera.org:8080/7265
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9fc34b6f8ff94098551e567f4aefa4e92a907f53
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes