You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2019/03/07 11:39:31 UTC

[GitHub] [storm] srdo opened a new pull request #2970: STORM-3354: Fix Nimbus not reentering leadership election in some cas…

srdo opened a new pull request #2970: STORM-3354: Fix Nimbus not reentering leadership election in some cas…
URL: https://github.com/apache/storm/pull/2970
 
 
   …es, and quit leadership election cleanly when Nimbus shuts down
   
   https://issues.apache.org/jira/browse/STORM-3354
   
   There are two issues here. 
   
   First that the LeaderElectorImp doesn't close the LeaderLatch when closed, which can cause a crash during Nimbus shutdown. 
   
   Second that if LeaderListenerCallback.leaderCallback decides not to be leader due to missing blobs, I believe Nimbus will stop trying to acquire leadership entirely. I haven't seen this happen, but I can't find any code that restarts the LeaderLatch.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services