You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "simicd (via GitHub)" <gi...@apache.org> on 2023/03/21 21:48:24 UTC

[GitHub] [arrow-datafusion-python] simicd opened a new pull request, #296: fix: Printed

simicd opened a new pull request, #296:
URL: https://github.com/apache/arrow-datafusion-python/pull/296

   # Which issue does this PR close?
   Closes #291
   
    # Rationale for this change
   Previously printing results (e.g. `.show()` method or `.explain()`) used Rust's `println!` macro. The results would not be visible in VS Code's debug console or in notebooks. Example:
   
   ![image](https://user-images.githubusercontent.com/10134699/226747883-a3199f41-a2f2-49d9-8134-8a55a7510236.png)
   
   
   # What changes are included in this PR?
   Use Python's builtin print function to resolve the issue and allow displaying results directly in the debugger & notebooks:
   
   ![image](https://user-images.githubusercontent.com/10134699/226748259-98570156-074e-4f35-a344-da8e16802ba6.png)
   
   
   # Are there any user-facing changes?
   `.show()` and `.explain()` newly display results
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion-python] simicd commented on pull request #296: fix: Printed results not visible in debugger & notebooks

Posted by "simicd (via GitHub)" <gi...@apache.org>.

simicd commented on PR #296:
URL: https://github.com/apache/arrow-datafusion-python/pull/296#issuecomment-1480245814

   You're welcome, thanks for the review @andygrove! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion-python] andygrove merged pull request #296: fix: Printed results not visible in debugger & notebooks

Posted by "andygrove (via GitHub)" <gi...@apache.org>.

andygrove merged PR #296:
URL: https://github.com/apache/arrow-datafusion-python/pull/296


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org