You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@texera.apache.org by "Xiao-zhen-Liu (via GitHub)" <gi...@apache.org> on 2025/10/06 18:29:58 UTC
[PR] refactor(config): remove user-sys enabled flag [texera]
Xiao-zhen-Liu opened a new pull request, #3831:
URL: https://github.com/apache/texera/pull/3831
# Purpose
This PR is a successor of #3782. As the non-user system mode is no longer used or maintained, we can remove the flag to switch between user-system being enabled/disabled, and keep only the mode of user-system being enabled.
# Content
- Removed the `user-sys.enabled` flag.
- Removed all the if-else statements based on this flag in the codebase. Only the cases of user system being enabled are kept.
- Removed `ExecutionResourceMapping` as it is no longer needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(config): remove user-sys enabled flag [texera]
Posted by "Xiao-zhen-Liu (via GitHub)" <gi...@apache.org>.
Xiao-zhen-Liu commented on code in PR #3831:
URL: https://github.com/apache/texera/pull/3831#discussion_r2418234121
##########
core/workflow-core/src/main/scala/edu/uci/ics/amber/core/storage/result/ExecutionResourcesMapping.scala:
##########
@@ -1,75 +0,0 @@
-/*
Review Comment:
Yes. `ExecutionResourcesMapping` was only used for the non-user-sys "dev mode" and is no longer needed now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(config): remove user-sys enabled flag [texera]
Posted by "Xiao-zhen-Liu (via GitHub)" <gi...@apache.org>.
Xiao-zhen-Liu commented on code in PR #3831:
URL: https://github.com/apache/texera/pull/3831#discussion_r2412195645
##########
.github/workflows/github-action-build.yml:
##########
@@ -119,6 +119,10 @@ jobs:
run: psql -h localhost -U postgres -v DB_NAME=texera_db_for_test_cases -f core/scripts/sql/texera_ddl.sql
env:
PGPASSWORD: postgres
+ - name: Create texera_db_for_test_cases
Review Comment:
Good catch, fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(config): remove user-sys enabled flag [texera]
Posted by "bobbai00 (via GitHub)" <gi...@apache.org>.
bobbai00 commented on code in PR #3831:
URL: https://github.com/apache/texera/pull/3831#discussion_r2418206946
##########
core/gui/src/app/workspace/service/workflow-cache/workflow-cache.service.ts:
##########
@@ -1,41 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
Ditto
##########
core/gui/src/app/workspace/service/workflow-cache/workflow-cache.service.spec.ts:
##########
@@ -1,234 +0,0 @@
-/**
Review Comment:
Why this file is removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(config): remove user-sys enabled flag [texera]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang commented on code in PR #3831:
URL: https://github.com/apache/texera/pull/3831#discussion_r2418191415
##########
core/workflow-core/src/main/scala/edu/uci/ics/amber/core/storage/result/ExecutionResourcesMapping.scala:
##########
@@ -1,75 +0,0 @@
-/*
Review Comment:
how come we can remove this one? where are those mappings stored now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(config): remove user-sys enabled flag [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan commented on code in PR #3831:
URL: https://github.com/apache/texera/pull/3831#discussion_r2418193027
##########
core/workflow-core/src/main/scala/edu/uci/ics/amber/core/storage/result/ExecutionResourcesMapping.scala:
##########
@@ -1,75 +0,0 @@
-/*
Review Comment:
in the database?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(config): remove user-sys enabled flag [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan commented on PR #3831:
URL: https://github.com/apache/texera/pull/3831#issuecomment-3383959630
@bobbai00 can review it first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(config): remove user-sys enabled flag [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan commented on code in PR #3831:
URL: https://github.com/apache/texera/pull/3831#discussion_r2418193027
##########
core/workflow-core/src/main/scala/edu/uci/ics/amber/core/storage/result/ExecutionResourcesMapping.scala:
##########
@@ -1,75 +0,0 @@
-/*
Review Comment:
in the database? @Xiao-zhen-Liu can confirm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(config): remove user-sys enabled flag [texera]
Posted by "Xiao-zhen-Liu (via GitHub)" <gi...@apache.org>.
Xiao-zhen-Liu commented on code in PR #3831:
URL: https://github.com/apache/texera/pull/3831#discussion_r2418234121
##########
core/workflow-core/src/main/scala/edu/uci/ics/amber/core/storage/result/ExecutionResourcesMapping.scala:
##########
@@ -1,75 +0,0 @@
-/*
Review Comment:
Yes. `ExecutionResourcesMapping` was only used for the "dev mode" and is no longer needed now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(config): remove user-sys enabled flag [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan commented on code in PR #3831:
URL: https://github.com/apache/texera/pull/3831#discussion_r2412171176
##########
.github/workflows/github-action-build.yml:
##########
@@ -119,6 +119,10 @@ jobs:
run: psql -h localhost -U postgres -v DB_NAME=texera_db_for_test_cases -f core/scripts/sql/texera_ddl.sql
env:
PGPASSWORD: postgres
+ - name: Create texera_db_for_test_cases
Review Comment:
This line is duplicated due to merge conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(config): remove user-sys enabled flag [texera]
Posted by "Xiao-zhen-Liu (via GitHub)" <gi...@apache.org>.
Xiao-zhen-Liu commented on code in PR #3831:
URL: https://github.com/apache/texera/pull/3831#discussion_r2418235548
##########
core/gui/src/app/workspace/service/workflow-cache/workflow-cache.service.spec.ts:
##########
@@ -1,234 +0,0 @@
-/**
Review Comment:
This was only used by the non-user-sys "dev mode" to cache a workflow JSON in the frontend and is no longer needed now that there is no dev mode.
##########
core/gui/src/app/workspace/service/workflow-cache/workflow-cache.service.ts:
##########
@@ -1,41 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
Ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(config): remove user-sys enabled flag [texera]
Posted by "Xiao-zhen-Liu (via GitHub)" <gi...@apache.org>.
Xiao-zhen-Liu merged PR #3831:
URL: https://github.com/apache/texera/pull/3831
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org