You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/08/05 14:04:28 UTC
[GitHub] [incubator-yunikorn-core] codecov[bot] commented on pull request #195: [YUNIKORN-343] Provide a placement rule that can support attaching NSs to parent queue
codecov[bot] commented on pull request #195:
URL: https://github.com/apache/incubator-yunikorn-core/pull/195#issuecomment-669212824
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/195?src=pr&el=h1) Report
> Merging [#195](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/195?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/357d71fa290619e583b5da0484215c5d927807b7&el=desc) will **decrease** coverage by `0.43%`.
> The diff coverage is `19.04%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/195?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #195 +/- ##
==========================================
- Coverage 60.08% 59.64% -0.44%
==========================================
Files 67 68 +1
Lines 6468 6500 +32
==========================================
- Hits 3886 3877 -9
- Misses 2441 2491 +50
+ Partials 141 132 -9
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/195?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/placement/mapping\_rule.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/195/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9wbGFjZW1lbnQvbWFwcGluZ19ydWxlLmdv) | `0.00% <0.00%> (ø)` | |
| [pkg/scheduler/placement/fixed\_rule.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/195/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9wbGFjZW1lbnQvZml4ZWRfcnVsZS5nbw==) | `68.42% <50.00%> (+5.15%)` | :arrow_up: |
| [pkg/scheduler/placement/provided\_rule.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/195/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9wbGFjZW1lbnQvcHJvdmlkZWRfcnVsZS5nbw==) | `78.78% <50.00%> (+8.33%)` | :arrow_up: |
| [pkg/scheduler/placement/user\_rule.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/195/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9wbGFjZW1lbnQvdXNlcl9ydWxlLmdv) | `76.66% <50.00%> (+8.37%)` | :arrow_up: |
| [pkg/scheduler/placement/rule.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/195/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9wbGFjZW1lbnQvcnVsZS5nbw==) | `79.59% <57.89%> (-13.75%)` | :arrow_down: |
| [pkg/scheduler/placement/tag\_rule.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/195/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9wbGFjZW1lbnQvdGFnX3J1bGUuZ28=) | `84.21% <100.00%> (+8.70%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/195?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/195?src=pr&el=footer). Last update [357d71f...1d1b35d](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/195?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org