You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/04/03 00:43:54 UTC

[jira] [Commented] (HELIX-589) Delete job API throws NPE if the job does not exist in last scheduled workflow

    [ https://issues.apache.org/jira/browse/HELIX-589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14393628#comment-14393628 ] 

ASF GitHub Bot commented on HELIX-589:
--------------------------------------

GitHub user jicongrui opened a pull request:

    https://github.com/apache/helix/pull/22

    [HELIX-589] Delete job API throws NPE if the job does not exist in last ...

    [HELIX-589] Delete job API throws NPE if the job does not exist in last scheduled workflow

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jicongrui/helix helix-0.6.x

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/helix/pull/22.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #22
    
----
commit e94a9f5f90099a248181d6dc50314aec0e8d9512
Author: Congrui Ji <cj...@linkedin.com>
Date:   2015-04-02T22:40:09Z

    [HELIX-589] Delete job API throws NPE if the job does not exist in last scheduled workflow

----


> Delete job API throws NPE if the job does not exist in last scheduled workflow
> ------------------------------------------------------------------------------
>
>                 Key: HELIX-589
>                 URL: https://issues.apache.org/jira/browse/HELIX-589
>             Project: Apache Helix
>          Issue Type: Bug
>            Reporter: Karthiek
>
> When trying to delete a job from a recurrent job queue, Helix throws NPE if the job does not exist in last scheduled workflow.
> java.lang.IllegalArgumentException: Could not remove job BackupJob_MailboxDB from DAG of queue BackupJobQueue_ESPRESSO_CHO_1_SCHEDULED_0
>         at org.apache.helix.task.TaskDriver.removeJobFromDag(TaskDriver.java:411)
>         at org.apache.helix.task.TaskDriver.deleteJobFromScheduledQueue(TaskDriver.java:345)
>         at org.apache.helix.task.TaskDriver.deleteJob(TaskDriver.java:303)
> It is possible for a user to add and immediately delete the job before the next workflow is scheduled. Helix should accommodate this case and check if the job exists in last scheduled workflow before trying to delete it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)