You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/04/21 19:06:00 UTC

[jira] [Commented] (CB-14047) Enhancement: Replacing Repeated String literals with final variables

    [ https://issues.apache.org/jira/browse/CB-14047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16446941#comment-16446941 ] 

ASF GitHub Bot commented on CB-14047:
-------------------------------------

hazems opened a new pull request #319: CB-14047: (android) CameraLauncher: Replacing Repeated String literals with final variables
URL: https://github.com/apache/cordova-plugin-camera/pull/319
 
 
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist
   is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   Android
   
   ### What does this PR do?
   Replacing Repeated String literals with final variables in CameraLauncher for having better maintainability and easier changes.
   
   ### What testing has been done on this change?
   Making sure that everything builds fine, also, run my own tests for Android Camera and all pass fine.
   
   ### Checklist
   - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
   - [x] Commit message follows the format: "CB-14047: (android) CameraLauncher: Replacing Repeated String literals with private final static variables"
   - [ ] Added automated test coverage as appropriate for this change.
   
   ### Notices
   I'm an old Apache Committer and a PMC member for another Apache project, so no worry about my CLA since I submitted it already.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Enhancement: Replacing Repeated String literals with final variables
> --------------------------------------------------------------------
>
>                 Key: CB-14047
>                 URL: https://issues.apache.org/jira/browse/CB-14047
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: cordova-plugin-camera
>    Affects Versions: cordova-android-7.0.0
>            Reporter: Hazem Saleh
>            Priority: Minor
>
> Replacing Repeated String literals with final variables.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org