[GitHub] [spark] beliefer commented on a change in pull request #36021: [SPARK-38709][SQL] Remove trailing $ from function class name in sql-expression-schema.md

[GitBox <gi...@apache.org>]

beliefer commented on a change in pull request #36021:
URL: https://github.com/apache/spark/pull/36021#discussion_r839443085



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
##########
@@ -184,10 +184,11 @@ object FunctionRegistryBase {
       } else {
         // This exists for the backward compatibility with old `ExpressionDescription`s defining
         // the extended description in `extended()`.
-        new ExpressionInfo(clazz.getCanonicalName, null, name, df.usage(), df.extended())
+        new ExpressionInfo(
+          clazz.getCanonicalName.stripSuffix("$"), null, name, df.usage(), df.extended())

Review comment:
       Could we extract `val canonicalName = clazz.getCanonicalName.stripSuffix("$")` ? It appears three times.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org