You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metron.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/05/15 15:25:00 UTC

[jira] [Commented] (METRON-1479) Add editorconfig - create guideline for code formatting in the angular part of the app

    [ https://issues.apache.org/jira/browse/METRON-1479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16475999#comment-16475999 ] 

ASF GitHub Bot commented on METRON-1479:
----------------------------------------

Github user sardell commented on the issue:

    https://github.com/apache/metron/pull/951
  
    I think this is a good addition, as .editorconfig is included by default with Angular CLI-generated projects and gives consistent formatting between different contributors' editors. However, I do think this PR is really big and could be a little scary for a PR reviewer to look at. If it's easier, maybe we can break down how this could be committed and submitted for an easier review. Should be relatively easy to recreate most of this work with VS code's Format Code option.


> Add editorconfig - create guideline for code formatting in the angular part of the app
> --------------------------------------------------------------------------------------
>
>                 Key: METRON-1479
>                 URL: https://issues.apache.org/jira/browse/METRON-1479
>             Project: Metron
>          Issue Type: Improvement
>            Reporter: Daniel Toth
>            Assignee: Daniel Toth
>            Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)