[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #4042: [CARBONDATA-4069] [CARBONDATA-4068] handled set streaming and long string for SI table or table having SI.

[GitBox <gi...@apache.org>]

VenuReddy2103 commented on a change in pull request #4042:
URL: https://github.com/apache/carbondata/pull/4042#discussion_r543752117



##########
File path: index/secondary-index/src/test/scala/org/apache/carbondata/spark/testsuite/secondaryindex/TestSIWithSecondaryIndex.scala
##########
@@ -434,6 +434,38 @@ class TestSIWithSecondaryIndex extends QueryTest with BeforeAndAfterAll {
     assert(df.exists(_.get(0).toString.contains("nam(e")))
   }
 
+  test("test alter table set streaming for table having SI") {
+    sql("drop table if exists maintable2")
+    sql("create table maintable2 (a string,b string,c int) STORED AS carbondata ")
+    sql("insert into maintable2 values('k','x',2)")
+    sql("create index m_indextable on table maintable2(b) AS 'carbondata'")
+    var exeption = intercept[RuntimeException] {

Review comment:
       IMO Intercepting specific exception - `UnsupportedOperationException` would be good rather than generic `RuntimeException`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org