You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2018/06/15 18:36:19 UTC

Review Request 67614: Removed memcpy from os::Fork::instantiate.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67614/
-----------------------------------------------------------

Review request for mesos and Benjamin Bannier.


Bugs: MESOS-9002
    https://issues.apache.org/jira/browse/MESOS-9002


Repository: mesos


Description
-------

GCC 8.1 warns about using `memcpy` to copy a `os::Fork::Tree::Memory`
struct because it doesn't have a trivial copy operator. We can replace
the `memcpy` with direct access to the structure fields, which has the
same effect.


Diffs
-----

  3rdparty/stout/include/stout/os/posix/fork.hpp 098224ee4abe73b61f180af3dac5989141e5908a 


Diff: https://reviews.apache.org/r/67614/diff/1/


Testing
-------

make check (Fedora 28)


Thanks,

James Peach