You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/07/21 08:50:29 UTC
[GitHub] [hadoop-ozone] elek commented on pull request #1224: HDDS-3991. Ignore protobuf lock files
elek commented on pull request #1224:
URL: https://github.com/apache/hadoop-ozone/pull/1224#issuecomment-661725337
> @elek how do we manually commit proto.lock updates?
Files can be committed even if they are on the `.gitignore` list with the `--force` option of `git add`.
But there is another problem here: git ignores ignore the changes only until they are added to the repo. If they are committed they will be tracked independent of the `.gitignore` file.
I updated the patch to follow a different approach: the check is executed from `target/classes` after the proto files and the lock files are copied (by maven resporce and proto plugins). At that time the update of the proto file is safe as target is ignored, but still we use the committed version of the lock file (which is copied).
Execute the latest patch and will see:
```
341 │ [INFO] --- proto-backwards-compatibility:1.0.5:backwards-compatibility-check (default) @ hadoop-hdds-interface-client ---
342 │ [INFO] Backwards compatibility check passed.
```
(When `proto.lock` is missing, a different message is printed out, sg. about initialization).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org