You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2020/09/03 21:46:20 UTC

[GitHub] [tinkerpop] divijvaidya commented on a change in pull request #1312: Make TinkerVertex non-final

divijvaidya commented on a change in pull request #1312:
URL: https://github.com/apache/tinkerpop/pull/1312#discussion_r483271227



##########
File path: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/GroupCountStep.java
##########
@@ -41,7 +41,7 @@
 /**
  * @author Marko A. Rodriguez (http://markorodriguez.com)
  */
-public final class GroupCountStep<S, E> extends ReducingBarrierStep<S, Map<E, Long>> implements TraversalParent, ByModulating {
+public class GroupCountStep<S, E> extends ReducingBarrierStep<S, Map<E, Long>> implements TraversalParent, ByModulating {

Review comment:
       Let me change the scope of this PR to only change visibility of certain members. We can pick up removing the final keyword after a discussion in email list.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org