You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/04/27 19:52:25 UTC

[GitHub] [solr] madrob opened a new pull request #98: Update IntelliJ paths

madrob opened a new pull request #98:
URL: https://github.com/apache/solr/pull/98


   I'm not sure if this change has other unintended side effects, but I needed it for my Structure101 plugin to work.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] madrob commented on pull request #98: Update IntelliJ paths

Posted by GitBox <gi...@apache.org>.
madrob commented on pull request #98:
URL: https://github.com/apache/solr/pull/98#issuecomment-827941462


   I imagined this was intentional, but didn't quite understand why. I suspect this was working around a bug in an older IntelliJ, maybe.
   
   For my particular install, IntelliJ builds don't even generate these directories, so it's hard to guess the intent behind them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] dweiss commented on pull request #98: Document why we use different paths for IntelliJ

Posted by GitBox <gi...@apache.org>.
dweiss commented on pull request #98:
URL: https://github.com/apache/solr/pull/98#issuecomment-830241383


   Thanks. And sorry for not being explicit in the build sometimes - some fragments are copy-pasted from my other projects and I didn't document them properly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] madrob merged pull request #98: Update IntelliJ paths

Posted by GitBox <gi...@apache.org>.
madrob merged pull request #98:
URL: https://github.com/apache/solr/pull/98


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] dweiss commented on pull request #98: Update IntelliJ paths

Posted by GitBox <gi...@apache.org>.
dweiss commented on pull request #98:
URL: https://github.com/apache/solr/pull/98#issuecomment-828159302


   It depends how you run intellij. Gradle settings window will give you options to compile/run with intellij or via gradle - the default seems to be gradle these days. I prefer IntelliJ's compiler (faster and more reliable). Overlapping output folders cause headaches especially on Windows where two concurrent tools lock files, etc. 
   
   If you really want this you could make it configurable (with the default separating builds) - a conditional on propertyOrDefault("ide.intellij.separateFolders", "true") and then override this setting locally (and document in help/ides.txt).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] madrob commented on pull request #98: Update IntelliJ paths

Posted by GitBox <gi...@apache.org>.
madrob commented on pull request #98:
URL: https://github.com/apache/solr/pull/98#issuecomment-830180193


   Makes sense. I decided that the Structure101 plugin wasn't worth it anyway, because it was having issues linking the byte code to the source code so lost a lot of power that way. Instead of changing the paths, I'll document more about the logic, hopefully somebody in the future will save themselves some time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] dweiss commented on pull request #98: Update IntelliJ paths

Posted by GitBox <gi...@apache.org>.
dweiss commented on pull request #98:
URL: https://github.com/apache/solr/pull/98#issuecomment-827902165


   In other words - this is an intentional configuration to separate output folders, not an oversight of some sort.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] dweiss commented on pull request #98: Update IntelliJ paths

Posted by GitBox <gi...@apache.org>.
dweiss commented on pull request #98:
URL: https://github.com/apache/solr/pull/98#issuecomment-827901584


   No, please keep these folders separate. If you overlap intellij and gradle outputs things start to look really weird when you're running from the IDE and from command-line at the same time. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org