[GitHub] [superset] amitmiran137 commented on a change in pull request #16917: refactor: sql lab command: separate concerns into different modules

[GitBox <gi...@apache.org>]

amitmiran137 commented on a change in pull request #16917:
URL: https://github.com/apache/superset/pull/16917#discussion_r724682563



##########
File path: superset/charts/dao.py
##########
@@ -14,6 +14,7 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
+# pylint: disable=arguments-renamed

Review comment:
       Hi @john-bodley  as you notice this is the only change that was done to the file.
   It was done bc all of a sudden pylint required it in the CI 
   
   The recent series of pylint rules changes that was done has awaken wiered behaviour and the CI and require us to work for the pylint instead of it working for us 
   
   We should focus on writing gold clean code instead of sharpening minor lint rules that will almost provide no real value 
   
   My opinion is that the reality in the field (superset backend) is much concerning around code maintenance ability and readability of the code rather then linting rules.
    linting all of sudden became a disturbance we need hop over on every PR 
   
   Try to develop a real feature your self and experience how linting is more in your way then helpful 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org