[jira] [Comment Edited] (HBASE-20199) Add test to prevent further permission regression around table flush and snapshot

["Ted Yu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-20199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16414924#comment-16414924 ] 

Ted Yu edited comment on HBASE-20199 at 3/27/18 3:19 AM:
---------------------------------------------------------

Looks good overall - if you want to rename the file, please also rename the class.

It seems {{testTableFlushAndSnapshot}} covers the other test.


was (Author: yuzhihong@gmail.com):
Looks good overall.

It seems {{testTableFlushAndSnapshot}} covers the other test.

> Add test to prevent further permission regression around table flush and snapshot
> ---------------------------------------------------------------------------------
>
>                 Key: HBASE-20199
>                 URL: https://issues.apache.org/jira/browse/HBASE-20199
>             Project: HBase
>          Issue Type: Task
>          Components: test
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>            Priority: Critical
>             Fix For: 2.0.0
>
>         Attachments: HBASE-20199.001.branch-2.0.patch, HBASE-20199.002.branch-2.0.patch
>
>
> {quote}
> There is already a test for that in TestAccessController- [https://github.com/apache/hbase/blob/master/hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java#L809], - however, those tests are hacked to not run the operations but the AC hooks directly. for eg. instead of triggering flush, it just runs ACCESS_CONTROLLER.preTableFlush(). It's not possible/good to change just a few tests there given that will break the overall design and make things harder to maintain.
> The new test should go in TestAdminOnlyOperations (and the test class name should probably be changed to TestRpcAccessChecks).
> {quote}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)