You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/04/08 15:27:28 UTC
[GitHub] [incubator-pinot] daniellavoie opened a new pull request #6758: Added guava cache package to common relocated packages
daniellavoie opened a new pull request #6758:
URL: https://github.com/apache/incubator-pinot/pull/6758
## Description
Our internal CI and local builds would encounter a classpath issue on `pinot-hadoop` test phase.
```
java.lang.NoSuchMethodError: com.google.common.cache.CacheBuilder.ticker(Lcom/google/common/base/Ticker;)Lcom/google/common/cache/CacheBuilder;
at org.apache.hadoop.security.Groups.<init>(Groups.java:99)
```
The root caused what identified using a `-verbose` jvm args overwrite on the `pinot-hadoop` maven module.
```
[Loaded com.google.common.cache.CacheBuilder from file:/Users/daniellavoie/.m2/repository/org/apache/pinot/pinot-common/0.7.0-SNAPSHOT/pinot-common-0.7.0-SNAPSHOT-shaded.jar]
```
The fix involves relocating the `com.google.common.cache` package of `pinot-common` to `shaded.com.google.common.cache`.
Fixes #6757
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #6758: Added guava cache package to common relocated packages
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang merged pull request #6758:
URL: https://github.com/apache/incubator-pinot/pull/6758
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #6758: Added guava cache package to common relocated packages
Posted by GitBox <gi...@apache.org>.
fx19880617 commented on a change in pull request #6758:
URL: https://github.com/apache/incubator-pinot/pull/6758#discussion_r609917933
##########
File path: pinot-common/pom.xml
##########
@@ -312,6 +312,10 @@
<pattern>com.google.common.base</pattern>
<shadedPattern>shaded.com.google.common.base</shadedPattern>
</relocation>
+ <relocation>
Review comment:
I think you also need to add this into the `pinot-plugins/pom.xml`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] daniellavoie commented on a change in pull request #6758: Added guava cache package to common relocated packages
Posted by GitBox <gi...@apache.org>.
daniellavoie commented on a change in pull request #6758:
URL: https://github.com/apache/incubator-pinot/pull/6758#discussion_r609919617
##########
File path: pinot-common/pom.xml
##########
@@ -312,6 +312,10 @@
<pattern>com.google.common.base</pattern>
<shadedPattern>shaded.com.google.common.base</shadedPattern>
</relocation>
+ <relocation>
Review comment:
I just want to fix the current error I faced and limit the side effects. I'll keep that in mind if we see another issue with a different module. I was able to get the local test working with only `pinot-common`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #6758: Added guava cache package to common relocated packages
Posted by GitBox <gi...@apache.org>.
fx19880617 commented on a change in pull request #6758:
URL: https://github.com/apache/incubator-pinot/pull/6758#discussion_r609917933
##########
File path: pinot-common/pom.xml
##########
@@ -312,6 +312,10 @@
<pattern>com.google.common.base</pattern>
<shadedPattern>shaded.com.google.common.base</shadedPattern>
</relocation>
+ <relocation>
Review comment:
I think you also need to add this into the `pinot-plugins/pom.xml`, so all plugin components will relocate the packages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org