You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@flume.apache.org by Alexander Alten-Lorenz <al...@cloudera.com> on 2012/02/29 11:10:08 UTC

Re: Review Request: Patch to fit the term agent, FLUME-999

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4105/
-----------------------------------------------------------

(Updated 2012-02-29 10:10:08.301927)


Review request for Flume.


Changes
-------

change terms into agent, testet with patch FLUME-1005


Summary
-------

Patch to fit the term agent, FLUME-999


This addresses bug FLUME-999.
    https://issues.apache.org/jira/browse/FLUME-999


Diffs
-----

  bin/flume-ng 0796a5b 

Diff: https://reviews.apache.org/r/4105/diff


Testing
-------


Thanks,

Alexander

Re: Review Request: Patch to fit the term agent, FLUME-999

Posted by Arvind Prabhakar <ar...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4105/#review6256
-----------------------------------------------------------


Thanks for the patch Alex. Some feedback:

* Please rebase it on the trunk.
* Please do not remove the term "node" but instead it should be deprecated. this means that it should now be shown in the usage/help output, but should continue to work with a warning that it is deprecated.

Thanks!



- Arvind


On 2012-02-29 10:10:08, Alexander Alten-Lorenz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4105/
> -----------------------------------------------------------
> 
> (Updated 2012-02-29 10:10:08)
> 
> 
> Review request for Flume.
> 
> 
> Summary
> -------
> 
> Patch to fit the term agent, FLUME-999
> 
> 
> This addresses bug FLUME-999.
>     https://issues.apache.org/jira/browse/FLUME-999
> 
> 
> Diffs
> -----
> 
>   bin/flume-ng 0796a5b 
> 
> Diff: https://reviews.apache.org/r/4105/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander
> 
>