[GitHub] sergeykolychev commented on a change in pull request #10555: MXNET-296 [Perl] Parity with Python Gluon Loss classes.

[GitBox <gi...@apache.org>]

sergeykolychev commented on a change in pull request #10555: MXNET-296 [Perl] Parity with Python Gluon Loss classes.
URL: https://github.com/apache/incubator-mxnet/pull/10555#discussion_r181799668
 
 

 ##########
 File path: perl-package/AI-MXNet/lib/AI/MXNet/Gluon/Loss.pm
 ##########
 @@ -75,19 +75,16 @@ method _apply_weighting(Str $F, GluonInput $loss, Maybe[Num] $weight=, Maybe[Glu
     return $loss;
 }
 
-# for symbolic output.shape is not available so we reshape
-# to empty shape and let it be inferred from output's shape
-# via the '-' operator later.
-
-method _reshape_label_as_output(GluonClass $F, GluonInput $output, GluonInput $label)
+# Reshapes x to the same shape as y
+method _reshape_like(GluonClass $F, GluonInput $x, GluonInput $y)
 
 Review comment:
   No, subroutines that start with underscore are private functions and are not part of public API.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services