You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2019/06/06 08:04:15 UTC
[kudu-CR] KUDU-2809 (6/6): reenable and update TestKuduScanner.testDiffScan
Hello Will Berkeley, Mike Percy, Grant Henke,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/13538
to review the following change.
Change subject: KUDU-2809 (6/6): reenable and update TestKuduScanner.testDiffScan
......................................................................
KUDU-2809 (6/6): reenable and update TestKuduScanner.testDiffScan
With all KUDU-2809 patches in, we can now reenable this test, after updating
it for the new diff scan semantics of course.
Change-Id: Ia466853736bfd769da4c51d6387bcd903df590ed
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java
1 file changed, 7 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/38/13538/1
--
To view, visit http://gerrit.cloudera.org:8080/13538
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia466853736bfd769da4c51d6387bcd903df590ed
Gerrit-Change-Number: 13538
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] KUDU-2809 (6/6): reenable and update TestKuduScanner.testDiffScan
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13538 )
Change subject: KUDU-2809 (6/6): reenable and update TestKuduScanner.testDiffScan
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13538
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia466853736bfd769da4c51d6387bcd903df590ed
Gerrit-Change-Number: 13538
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 06 Jun 2019 21:48:39 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2809 (6/6): reenable and update TestKuduScanner.testDiffScan
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13538 )
Change subject: KUDU-2809 (6/6): reenable and update TestKuduScanner.testDiffScan
......................................................................
Patch Set 8:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13538/7/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java:
http://gerrit.cloudera.org:8080/#/c/13538/7/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java@311
PS7, Line 311: DELETEs won't be found in the results
> It would seem fine to me to simply copy / paste the setup part of the test
Gotcha, so not a fuzz test but something targeted. I'll give it a shot.
--
To view, visit http://gerrit.cloudera.org:8080/13538
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia466853736bfd769da4c51d6387bcd903df590ed
Gerrit-Change-Number: 13538
Gerrit-PatchSet: 8
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 07 Jun 2019 23:27:06 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2809 (6/6): reenable and update TestKuduScanner.testDiffScan
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13538 )
Change subject: KUDU-2809 (6/6): reenable and update TestKuduScanner.testDiffScan
......................................................................
Patch Set 7:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13538/7/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java:
http://gerrit.cloudera.org:8080/#/c/13538/7/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java@311
PS7, Line 311: DELETEs won't be found in the results
> It looks like this test was our only Java client test with coverage of IS_D
I don't see an easy way to do that without rewriting the entire test. Can you suggest a path forward?
--
To view, visit http://gerrit.cloudera.org:8080/13538
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia466853736bfd769da4c51d6387bcd903df590ed
Gerrit-Change-Number: 13538
Gerrit-PatchSet: 7
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 07 Jun 2019 21:34:20 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2809 (6/6): reenable and update TestKuduScanner.testDiffScan
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13538 )
Change subject: KUDU-2809 (6/6): reenable and update TestKuduScanner.testDiffScan
......................................................................
Patch Set 8:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13538/7/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java:
http://gerrit.cloudera.org:8080/#/c/13538/7/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java@311
PS7, Line 311: DELETEs won't be found in the results
> I don't see an easy way to do that without rewriting the entire test. Can y
It would seem fine to me to simply copy / paste the setup part of the test (schema / table creation) and then insert a row, get start timestamp, delete a row, get end timestamp, diff scan(start, end) returns a single deleted row. It would be a pretty short unit test and maintain Java client coverage of IS_DELETED.
--
To view, visit http://gerrit.cloudera.org:8080/13538
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia466853736bfd769da4c51d6387bcd903df590ed
Gerrit-Change-Number: 13538
Gerrit-PatchSet: 8
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 07 Jun 2019 22:20:19 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2809 (6/6): reenable and update TestKuduScanner.testDiffScan
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13538 )
Change subject: KUDU-2809 (6/6): reenable and update TestKuduScanner.testDiffScan
......................................................................
KUDU-2809 (6/6): reenable and update TestKuduScanner.testDiffScan
With all KUDU-2809 patches in, we can now reenable this test, after updating
it for the new diff scan semantics of course.
I also added a smaller unit test targeted at deleted rows, since the new
semantics guarantee that we won't see any in testDiffScan.
Change-Id: Ia466853736bfd769da4c51d6387bcd903df590ed
Reviewed-on: http://gerrit.cloudera.org:8080/13538
Reviewed-by: Mike Percy <mp...@apache.org>
Tested-by: Kudu Jenkins
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java
1 file changed, 42 insertions(+), 8 deletions(-)
Approvals:
Mike Percy: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/13538
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia466853736bfd769da4c51d6387bcd903df590ed
Gerrit-Change-Number: 13538
Gerrit-PatchSet: 10
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] KUDU-2809 (6/6): reenable and update TestKuduScanner.testDiffScan
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13538 )
Change subject: KUDU-2809 (6/6): reenable and update TestKuduScanner.testDiffScan
......................................................................
Patch Set 7:
(1 comment)
Are
http://gerrit.cloudera.org:8080/#/c/13538/7/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java:
http://gerrit.cloudera.org:8080/#/c/13538/7/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java@311
PS7, Line 311: DELETEs won't be found in the results
It looks like this test was our only Java client test with coverage of IS_DELETED, so we should add back coverage for that.
--
To view, visit http://gerrit.cloudera.org:8080/13538
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia466853736bfd769da4c51d6387bcd903df590ed
Gerrit-Change-Number: 13538
Gerrit-PatchSet: 7
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 07 Jun 2019 18:51:55 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2809 (6/6): reenable and update TestKuduScanner.testDiffScan
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Mike Percy, Kudu Jenkins, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13538
to look at the new patch set (#2).
Change subject: KUDU-2809 (6/6): reenable and update TestKuduScanner.testDiffScan
......................................................................
KUDU-2809 (6/6): reenable and update TestKuduScanner.testDiffScan
With all KUDU-2809 patches in, we can now reenable this test, after updating
it for the new diff scan semantics of course.
Change-Id: Ia466853736bfd769da4c51d6387bcd903df590ed
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java
1 file changed, 7 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/38/13538/2
--
To view, visit http://gerrit.cloudera.org:8080/13538
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia466853736bfd769da4c51d6387bcd903df590ed
Gerrit-Change-Number: 13538
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] KUDU-2809 (6/6): reenable and update TestKuduScanner.testDiffScan
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Mike Percy, Kudu Jenkins, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13538
to look at the new patch set (#9).
Change subject: KUDU-2809 (6/6): reenable and update TestKuduScanner.testDiffScan
......................................................................
KUDU-2809 (6/6): reenable and update TestKuduScanner.testDiffScan
With all KUDU-2809 patches in, we can now reenable this test, after updating
it for the new diff scan semantics of course.
I also added a smaller unit test targeted at deleted rows, since the new
semantics guarantee that we won't see any in testDiffScan.
Change-Id: Ia466853736bfd769da4c51d6387bcd903df590ed
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java
1 file changed, 42 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/38/13538/9
--
To view, visit http://gerrit.cloudera.org:8080/13538
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia466853736bfd769da4c51d6387bcd903df590ed
Gerrit-Change-Number: 13538
Gerrit-PatchSet: 9
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] KUDU-2809 (6/6): reenable and update TestKuduScanner.testDiffScan
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13538 )
Change subject: KUDU-2809 (6/6): reenable and update TestKuduScanner.testDiffScan
......................................................................
Patch Set 9: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13538/7/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java:
http://gerrit.cloudera.org:8080/#/c/13538/7/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java@311
PS7, Line 311: DELETEs won't be found in the results
> Gotcha, so not a fuzz test but something targeted. I'll give it a shot.
Thanks, looks good to me
--
To view, visit http://gerrit.cloudera.org:8080/13538
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia466853736bfd769da4c51d6387bcd903df590ed
Gerrit-Change-Number: 13538
Gerrit-PatchSet: 9
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 07 Jun 2019 23:43:30 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2809 (6/6): reenable and update TestKuduScanner.testDiffScan
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13538 )
Change subject: KUDU-2809 (6/6): reenable and update TestKuduScanner.testDiffScan
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13538
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia466853736bfd769da4c51d6387bcd903df590ed
Gerrit-Change-Number: 13538
Gerrit-PatchSet: 6
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 07 Jun 2019 15:02:55 +0000
Gerrit-HasComments: No