You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/08/31 22:12:23 UTC
[GitHub] [spark] carylee opened a new pull request #33880: [SPARK-36617] Fix type hints for `approxQuantile` to support multi-column version
carylee opened a new pull request #33880:
URL: https://github.com/apache/spark/pull/33880
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
Update both `DataFrame.approxQuantile` and `DataFrameStatFunctions.approxQuantile` to support overloaded definitions when multiple columns are supplied.
### Why are the changes needed?
The current type hints don't support the multi-column signature, a form that was added in Spark 2.2 (see [the approxQuantile docs](https://spark.apache.org/docs/latest/api/python/reference/api/pyspark.sql.DataFrame.approxQuantile.html).) This change was also introduced to pyspark-stubs (https://github.com/zero323/pyspark-stubs/pull/552). @zero323 asked me to open a PR for the upstream change.
### Does this PR introduce _any_ user-facing change?
This change only affects type hints - it brings the `approxQuantile` type hints up to date with the actual code.
### How was this patch tested?
Ran `./dev/lint-python`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] carylee commented on pull request #33880: [SPARK-36617] Fix type hints for `approxQuantile` to support multi-column version
Posted by GitBox <gi...@apache.org>.
carylee commented on pull request #33880:
URL: https://github.com/apache/spark/pull/33880#issuecomment-909761570
I'm not sure what the problems is. My branch is in sync with upstream/master and Github actions are enabled (see below):
<img width="2059" alt="Screen Shot 2021-08-31 at 4 39 36 PM" src="https://user-images.githubusercontent.com/135997/131589408-57955afe-083a-47a0-bf99-a4468dacabe3.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33880: [SPARK-36617][PYTHON] Fix type hints for `approxQuantile` to support multi-column version
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33880:
URL: https://github.com/apache/spark/pull/33880#issuecomment-909989289
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] carylee commented on pull request #33880: [SPARK-36617][PYTHON] Fix type hints for `approxQuantile` to support multi-column version
Posted by GitBox <gi...@apache.org>.
carylee commented on pull request #33880:
URL: https://github.com/apache/spark/pull/33880#issuecomment-911000872
@zero323 It looks like the tests passed? https://github.com/carylee/spark/actions/runs/1191206733
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 commented on pull request #33880: [SPARK-36617] Fix type hints for `approxQuantile` to support multi-column version
Posted by GitBox <gi...@apache.org>.
zero323 commented on pull request #33880:
URL: https://github.com/apache/spark/pull/33880#issuecomment-909703319
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 closed pull request #33880: [SPARK-36617][PYTHON] Fix type hints for `approxQuantile` to support multi-column version
Posted by GitBox <gi...@apache.org>.
zero323 closed pull request #33880:
URL: https://github.com/apache/spark/pull/33880
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33880: [SPARK-36617][PYTHON] Fix type hints for `approxQuantile` to support multi-column version
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33880:
URL: https://github.com/apache/spark/pull/33880#issuecomment-909989289
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 commented on pull request #33880: [SPARK-36617][PYTHON] Fix type hints for `approxQuantile` to support multi-column version
Posted by GitBox <gi...@apache.org>.
zero323 commented on pull request #33880:
URL: https://github.com/apache/spark/pull/33880#issuecomment-911666324
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] carylee commented on pull request #33880: [SPARK-36617] Fix type hints for `approxQuantile` to support multi-column version
Posted by GitBox <gi...@apache.org>.
carylee commented on pull request #33880:
URL: https://github.com/apache/spark/pull/33880#issuecomment-909761570
I'm not sure what the problems is. My branch is in sync with upstream/master and Github actions are enabled (see below):
<img width="2059" alt="Screen Shot 2021-08-31 at 4 39 36 PM" src="https://user-images.githubusercontent.com/135997/131589408-57955afe-083a-47a0-bf99-a4468dacabe3.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33880: [SPARK-36617] Fix type hints for `approxQuantile` to support multi-column version
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33880:
URL: https://github.com/apache/spark/pull/33880#issuecomment-909684622
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #33880: [SPARK-36617][PYTHON] Fix type hints for `approxQuantile` to support multi-column version
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #33880:
URL: https://github.com/apache/spark/pull/33880#issuecomment-911627629
I think it's good to go and merge since GitHub Actions passed. This change shouldn't break any of tests anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33880: [SPARK-36617] Fix type hints for `approxQuantile` to support multi-column version
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33880:
URL: https://github.com/apache/spark/pull/33880#issuecomment-909684622
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33880: [SPARK-36617] Fix type hints for `approxQuantile` to support multi-column version
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33880:
URL: https://github.com/apache/spark/pull/33880#issuecomment-909684622
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 commented on pull request #33880: [SPARK-36617][PYTHON] Fix type hints for `approxQuantile` to support multi-column version
Posted by GitBox <gi...@apache.org>.
zero323 commented on pull request #33880:
URL: https://github.com/apache/spark/pull/33880#issuecomment-910856661
ok to test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 commented on pull request #33880: [SPARK-36617][PYTHON] Fix type hints for `approxQuantile` to support multi-column version
Posted by GitBox <gi...@apache.org>.
zero323 commented on pull request #33880:
URL: https://github.com/apache/spark/pull/33880#issuecomment-909768679
Could you check your actions tab (https://github.com/carylee/spark/actions) directly (you might see something like described in [this comment](https://github.com/apache/spark/pull/32400#issuecomment-831051189))?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 commented on pull request #33880: [SPARK-36617] Fix type hints for `approxQuantile` to support multi-column version
Posted by GitBox <gi...@apache.org>.
zero323 commented on pull request #33880:
URL: https://github.com/apache/spark/pull/33880#issuecomment-909704890
Thanks for your contribution @carylee. Could you check the [error](https://github.com/apache/spark/pull/33880/checks?check_run_id=3478166282) and follow the instructions there? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33880: [SPARK-36617] Fix type hints for `approxQuantile` to support multi-column version
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33880:
URL: https://github.com/apache/spark/pull/33880#issuecomment-909684622
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 commented on pull request #33880: [SPARK-36617] Fix type hints for `approxQuantile` to support multi-column version
Posted by GitBox <gi...@apache.org>.
zero323 commented on pull request #33880:
URL: https://github.com/apache/spark/pull/33880#issuecomment-909750387
Could you also add `[PYTHON]` to the title (it should be `[SPARK-36617][PYTHON] ...`)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #33880: [SPARK-36617][PYTHON] Fix type hints for `approxQuantile` to support multi-column version
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #33880:
URL: https://github.com/apache/spark/pull/33880#issuecomment-911617748
ok to test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 commented on pull request #33880: [SPARK-36617] Fix type hints for `approxQuantile` to support multi-column version
Posted by GitBox <gi...@apache.org>.
zero323 commented on pull request #33880:
URL: https://github.com/apache/spark/pull/33880#issuecomment-909703319
ok to test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 commented on pull request #33880: [SPARK-36617][PYTHON] Fix type hints for `approxQuantile` to support multi-column version
Posted by GitBox <gi...@apache.org>.
zero323 commented on pull request #33880:
URL: https://github.com/apache/spark/pull/33880#issuecomment-910863753
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 commented on pull request #33880: [SPARK-36617][PYTHON] Fix type hints for `approxQuantile` to support multi-column version
Posted by GitBox <gi...@apache.org>.
zero323 commented on pull request #33880:
URL: https://github.com/apache/spark/pull/33880#issuecomment-910891274
test this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 commented on a change in pull request #33880: [SPARK-36617] Fix type hints for `approxQuantile` to support multi-column version
Posted by GitBox <gi...@apache.org>.
zero323 commented on a change in pull request #33880:
URL: https://github.com/apache/spark/pull/33880#discussion_r699753404
##########
File path: python/pyspark/sql/dataframe.pyi
##########
@@ -270,7 +278,9 @@ class DataFrame(PandasMapOpsMixin, PandasConversionMixin):
def semanticHash(self) -> int: ...
def inputFiles(self) -> List[str]: ...
def writeTo(self, table: str) -> DataFrameWriterV2: ...
- def to_pandas_on_spark(self, index_col: Optional[Union[str, List[str]]] = None) -> PandasOnSparkDataFrame: ...
+ def to_pandas_on_spark(
Review comment:
Let's keep unrelated code as-is for now, without reformatting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 commented on a change in pull request #33880: [SPARK-36617] Fix type hints for `approxQuantile` to support multi-column version
Posted by GitBox <gi...@apache.org>.
zero323 commented on a change in pull request #33880:
URL: https://github.com/apache/spark/pull/33880#discussion_r699753404
##########
File path: python/pyspark/sql/dataframe.pyi
##########
@@ -270,7 +278,9 @@ class DataFrame(PandasMapOpsMixin, PandasConversionMixin):
def semanticHash(self) -> int: ...
def inputFiles(self) -> List[str]: ...
def writeTo(self, table: str) -> DataFrameWriterV2: ...
- def to_pandas_on_spark(self, index_col: Optional[Union[str, List[str]]] = None) -> PandasOnSparkDataFrame: ...
+ def to_pandas_on_spark(
Review comment:
Let's keep unrelated code as-is for now, without reformatting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 removed a comment on pull request #33880: [SPARK-36617][PYTHON] Fix type hints for `approxQuantile` to support multi-column version
Posted by GitBox <gi...@apache.org>.
zero323 removed a comment on pull request #33880:
URL: https://github.com/apache/spark/pull/33880#issuecomment-910863753
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org