You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/03/13 19:15:00 UTC
[jira] [Work logged] (KNOX-1820) Cleanup KeystoreService
implementations and add unit tests
[ https://issues.apache.org/jira/browse/KNOX-1820?focusedWorklogId=212628&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-212628 ]
ASF GitHub Bot logged work on KNOX-1820:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Mar/19 19:14
Start Date: 13/Mar/19 19:14
Worklog Time Spent: 10m
Work Description: rlevas commented on pull request #72: KNOX-1820 - Cleanup KeystoreService implementations and add unit tests
URL: https://github.com/apache/knox/pull/72
## What changes were proposed in this pull request?
Removed the following unneeded classes:
- `org.apache.knox.gateway.services.security.impl.BaseKeystoreService`
- `org.apache.knox.gateway.services.security.impl.CMFKeystoreService`
- `org.apache.knox.gateway.services.security.impl.CMFKeystoreServiceTest`
Copied relevant members of `org.apache.knox.gateway.services.security.impl.BaseKeystoreService` to `org.apache.knox.gateway.services.security.impl.DefaultKeystoreService`.
Cleaned up `org.apache.knox.gateway.services.security.impl.DefaultKeystoreService`
- Utilized reusable code blocks
- Converted `java.io.File`s to `java.nio.file.Path`s
Added unit test cases to `org.apache.knox.gateway.services.security.impl.DefaultKeystoreServiceTest`
## How was this patch tested?
```
mvn -T.5C verify -Prelease,package
...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 16:02 min (Wall Clock)
[INFO] Finished at: 2019-03-13T15:01:33-04:00
[INFO] Final Memory: 270M/1891M
[INFO] ------------------------------------------------------------------------
```
Please review [Knox Contributing Process](https://cwiki.apache.org/confluence/display/KNOX/Contribution+Process#ContributionProcess-GithubWorkflow) before opening a pull request.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 212628)
Time Spent: 10m
Remaining Estimate: 0h
> Cleanup KeystoreService implementations and add unit tests
> ----------------------------------------------------------
>
> Key: KNOX-1820
> URL: https://issues.apache.org/jira/browse/KNOX-1820
> Project: Apache Knox
> Issue Type: Improvement
> Components: Server
> Reporter: Robert Levas
> Assignee: Robert Levas
> Priority: Minor
> Labels: cleanup
> Fix For: 1.3.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {{org.apache.knox.gateway.services.security.impl.BaseKeystoreService}} should be an abstract class extended by {{org.apache.knox.gateway.services.security.impl.CMFKeystoreService}} and {{DefaultKeystoreService}.
> Unit test for these classes are missing and should be added.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)