[GitHub] [tvm] AndrewZhaoLuo commented on pull request #8347: Switch threading model to `fork` on macOS

[GitBox <gi...@apache.org>]

AndrewZhaoLuo commented on pull request #8347:
URL: https://github.com/apache/tvm/pull/8347#issuecomment-869825939


   Hmm I personally don't think this is the right move. This has serious
   sideffects on program behavior.
   
   For example, if a user is running other scripts besides TVM in the same
   session it could cause unexpected behavior. I think the best thing is
   having the users manually change things and we focus on giving the user a
   proper error message if we detect this error is applicable.
   
   On Mon, Jun 28, 2021, 2:44 AM Leandro Nunes ***@***.***>
   wrote:
   
   > ***@***.**** commented on this pull request.
   >
   > I understand this will fix the immediate problem reported. I just wonder
   > whether this shouldn't be fixed at import tvm level, considering the
   > usages via the Python API.
   >
   > In case there agreement to fix this here, I'm also happy to take this PR.
   >
   > also cc @comaniac <https://github.com/comaniac>
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/tvm/pull/8347#pullrequestreview-693760359>, or
   > unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/ADJWVW7BUEVQKG34UTG4M6DTVA77XANCNFSM47KU3X7Q>
   > .
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org