[GitHub] [arrow-datafusion] crepererum commented on a diff in pull request #6129: fix: `common_subexpr_eliminate` and aggregates

["crepererum (via GitHub)" <gi...@apache.org>]

crepererum commented on code in PR #6129:
URL: https://github.com/apache/arrow-datafusion/pull/6129#discussion_r1178074706


##########
datafusion/optimizer/src/common_subexpr_eliminate.rs:
##########
@@ -352,6 +462,49 @@ fn build_recover_project_plan(schema: &DFSchema, input: LogicalPlan) -> LogicalP
     )
 }
 
+/// Which type of [expressions](Expr) should be considered for rewriting?

Review Comment:
   While this resulted in more code, I've decided to pull the masking out into its own enum / config value so the code is easier to read and extend (I could imagine that we may wanna have more special treatments for other logical plan nodes at some point).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org