You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@superset.apache.org by mi...@apache.org on 2023/12/27 12:31:22 UTC

(superset) 04/14: chore: Use WEBDRIVER_OPTION_ARGS with Playwright (#26315)

This is an automated email from the ASF dual-hosted git repository.

michaelsmolina pushed a commit to branch 3.1
in repository https://gitbox.apache.org/repos/asf/superset.git

commit b5cb3ec13c071c28cea90ee9c86973019c60d73d
Author: Kamil Gabryjelski <ka...@gmail.com>
AuthorDate: Wed Dec 20 12:42:12 2023 +0100

    chore: Use WEBDRIVER_OPTION_ARGS with Playwright (#26315)
    
    (cherry picked from commit 3f9183a1628672d22e97284dfe9046d77a09e9fe)
---
 superset/utils/webdriver.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/superset/utils/webdriver.py b/superset/utils/webdriver.py
index f7814bfd3b..4552600fc9 100644
--- a/superset/utils/webdriver.py
+++ b/superset/utils/webdriver.py
@@ -137,7 +137,8 @@ class WebDriverPlaywright(WebDriverProxy):
         self, url: str, element_name: str, user: User
     ) -> bytes | None:
         with sync_playwright() as playwright:
-            browser = playwright.chromium.launch()
+            browser_args = current_app.config["WEBDRIVER_OPTION_ARGS"]
+            browser = playwright.chromium.launch(args=browser_args)
             pixel_density = current_app.config["WEBDRIVER_WINDOW"].get(
                 "pixel_density", 1
             )