You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/28 14:28:38 UTC
[GitHub] [arrow-datafusion] Dandandan opened a new pull request, #4000: Fix output schema on added projection of HashBuildProbeOrder
Dandandan opened a new pull request, #4000:
URL: https://github.com/apache/arrow-datafusion/pull/4000
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Dandandan merged pull request #4000: Don't add projection for semi joins in HashBuildProbeOrder
Posted by GitBox <gi...@apache.org>.
Dandandan merged PR #4000:
URL: https://github.com/apache/arrow-datafusion/pull/4000
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #4000: Don't add projection for semi joins in HashBuildProbeOrder
Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #4000:
URL: https://github.com/apache/arrow-datafusion/pull/4000#discussion_r1008452816
##########
datafusion/core/src/physical_optimizer/hash_build_probe_order.rs:
##########
@@ -174,6 +174,13 @@ impl PhysicalOptimizerRule for HashBuildProbeOrder {
*hash_join.partition_mode(),
hash_join.null_equals_null(),
)?;
+ if matches!(
Review Comment:
Although maybe Anti joins don't have their inputs swapped so it can't happen 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #4000: Don't add projection for semi joins in HashBuildProbeOrder
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #4000:
URL: https://github.com/apache/arrow-datafusion/pull/4000#issuecomment-1295464870
Benchmark runs are scheduled for baseline = ca42f4cdb9ce3cddd46447d289b3a89824b7e8d7 and contender = 925a96225e2142d8adc53a3323ddf612fffe2007. 925a96225e2142d8adc53a3323ddf612fffe2007 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/4b105cbf74a34d499d7e2a036840ddc8...6653b3a1b67a4f4eb8708112f24e3722/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/208e4c7ed59140c188ca58124ac90572...179361a526674a4db9094c95f7035710/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/2a1380c4cd4f4c2b844843d93a44806d...bef50d5c47284822ac80fa3d7a456bb2/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/896ebaf393d94c3bac4d8d0a6c1e07d4...b52d32e533e54e1399039b6c77c46c2a/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Dandandan commented on a diff in pull request #4000: Don't add projection for semi joins in HashBuildProbeOrder
Posted by GitBox <gi...@apache.org>.
Dandandan commented on code in PR #4000:
URL: https://github.com/apache/arrow-datafusion/pull/4000#discussion_r1008459727
##########
datafusion/core/src/physical_optimizer/hash_build_probe_order.rs:
##########
@@ -174,6 +174,13 @@ impl PhysicalOptimizerRule for HashBuildProbeOrder {
*hash_join.partition_mode(),
hash_join.null_equals_null(),
)?;
+ if matches!(
Review Comment:
Indeed. I figured it could be added later when RightAnti is implemented. I will add a note to the ticket.
One thing I also observed is that adding the projection for other types wouldn't be needed if we would update the join columns itself instead of fixing it afterwards, but that requires some more plumbing to get right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #4000: Don't add projection for semi joins in HashBuildProbeOrder
Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #4000:
URL: https://github.com/apache/arrow-datafusion/pull/4000#discussion_r1008452215
##########
datafusion/core/src/physical_optimizer/hash_build_probe_order.rs:
##########
@@ -174,6 +174,13 @@ impl PhysicalOptimizerRule for HashBuildProbeOrder {
*hash_join.partition_mode(),
hash_join.null_equals_null(),
)?;
+ if matches!(
Review Comment:
I think the same test should apply to `Anti` joins as well, should it not?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org