You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/12/07 21:40:58 UTC

[GitHub] [lucene-solr] mayya-sharipova opened a new pull request #2129: Fix format indent from 4 to 2 spaces

mayya-sharipova opened a new pull request #2129:
URL: https://github.com/apache/lucene-solr/pull/2129


   Files in org.apache.lucene.search.comparators package
   has a wrong indent of 4 spaces instead of 2.
   This patch fixes only the indent from 4 to correct 2 spaces


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] ErickErickson commented on pull request #2129: Fix format indent from 4 to 2 spaces

Posted by GitBox <gi...@apache.org>.
ErickErickson commented on pull request #2129:
URL: https://github.com/apache/lucene-solr/pull/2129#issuecomment-742891680


   It already fails on _tabs_ rather than spaces, but failing on too many spaces isn’t checked.
   
   That said, rather than a one-off for indentation, I’d rather see the effort go here
   rather than a separate precommit check….:
   
   https://issues.apache.org/jira/browse/LUCENE-9564 and SOLR-14920…
   
   BTW, 'gradlew check’ does all the precommit tasks as well as run tests...
   
   > On Dec 10, 2020, at 2:55 PM, Mayya Sharipova <no...@github.com> wrote:
   > 
   > 
   > Merged #2129 into master.
   > 
   > —
   > You are receiving this because you are subscribed to this thread.
   > Reply to this email directly, view it on GitHub, or unsubscribe.
   > 
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] mayya-sharipova commented on pull request #2129: Fix format indent from 4 to 2 spaces

Posted by GitBox <gi...@apache.org>.
mayya-sharipova commented on pull request #2129:
URL: https://github.com/apache/lucene-solr/pull/2129#issuecomment-744587079


   @ErickErickson Thanks for your suggestions, and letting me know about LUCENE-9564, I will keep watching this issue. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] mayya-sharipova merged pull request #2129: Fix format indent from 4 to 2 spaces

Posted by GitBox <gi...@apache.org>.
mayya-sharipova merged pull request #2129:
URL: https://github.com/apache/lucene-solr/pull/2129


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] msokolov commented on pull request #2129: Fix format indent from 4 to 2 spaces

Posted by GitBox <gi...@apache.org>.
msokolov commented on pull request #2129:
URL: https://github.com/apache/lucene-solr/pull/2129#issuecomment-741784170


   Thanks for fixing - I have another one I need to do, too, and I wonder if we shouldn't just push uncontroversial changes like this directly? No need to wait for review I think. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] mayya-sharipova commented on pull request #2129: Fix format indent from 4 to 2 spaces

Posted by GitBox <gi...@apache.org>.
mayya-sharipova commented on pull request #2129:
URL: https://github.com/apache/lucene-solr/pull/2129#issuecomment-742759335


   @msokolov  Thanks for your comment. Indeed having a  `gradlew precommit` to fail on inconsistent code style would be useful.
   
   Thanks for feedback, I will merge the PR. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org