[hadoop] branch trunk updated: HADOOP-15989. Synchronized at CompositeService#removeService is not required. Contributed by Prabhu Joseph.

[we...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

weichiu pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/hadoop.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 371452e  HADOOP-15989. Synchronized at CompositeService#removeService is not required. Contributed by Prabhu Joseph.
371452e is described below

commit 371452e26005a483b069cc8d558ec1b4eb6f2e0e
Author: Prabhu Joseph <pj...@cloudera.com>
AuthorDate: Fri Jun 21 17:02:54 2019 -0700

    HADOOP-15989. Synchronized at CompositeService#removeService is not required. Contributed by Prabhu Joseph.
    
    Signed-off-by: Wei-Chiu Chuang <we...@apache.org>
---
 .../src/main/java/org/apache/hadoop/service/CompositeService.java      | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/service/CompositeService.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/service/CompositeService.java
index a5e8c89..4aa2f23 100644
--- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/service/CompositeService.java
+++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/service/CompositeService.java
@@ -93,7 +93,8 @@ public class CompositeService extends AbstractService {
     }
   }
 
-  protected synchronized boolean removeService(Service service) {
+  protected boolean removeService(Service service) {
+    LOG.debug("Removing service {}", service.getName());
     synchronized (serviceList) {
       return serviceList.remove(service);
     }


---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-commits-help@hadoop.apache.org