Re: [DISCUSS] cordova-lib 11.1.0 Release

[Norman Breau <no...@nbsolutions.ca>]

As mentioned in the vote thread,

I created a issue with a detailed explanation on the failing test, which 
can be viewed at
https://github.com/apache/cordova-lib/issues/906

If you're curious or suspicious when casting your vote, then hopefully 
those details can ease your mind.

On 2022-12-21 7:34 p.m., julio cesar sanchez wrote:
> Ok, I think we should do a minor since we include the deprecation of some
> platforms and then we can do a major soon removing those deprecated
> platforms and the pinning for the remaining.
>
>
> El El mar, 13 dic 2022 a las 18:22, Norman Breau <no...@nbsolutions.ca>
> escribió:
>
>> Bumping a pin from android v10 to v11 should be considered a breaking
>> change.
>> If users are relying on this behavior in scripts or builds, it may
>> unexpectedly break.
>>
>> Removing the pin logic while I think I agree with, it's still changing
>> the behavior so would
>> also be considered a breaking change. But if we proceed with that we can
>> explain in the
>> release blog that they can specify a version if they want to assert a
>> specific version, e.g:
>>
>> cordova platform add android@11
>>
>> So we should probably wait before we change the pin logic until we build
>> a cordova-lib@12
>> regardless if we decide to remove the pinning logic altogether, or
>> simply bump the android pin.
>>
>> On 2022-12-13 1:13 p.m., Bryan Ellis wrote:
>>> I am not entirely sure. I believe we had only pinned the platform major
>>> with a major release.
>>>
>>>
>>> I think the pinning logic should be removed. That is why I created this
>> PR
>>> for the next major: https://github.com/apache/cordova-lib/pull/894
>>>
>>>
>>> I feel that "cordova platform add <platform>" should always install the
>>> latest, and if any user wants a specific version, they should supply it.
>>> "<platform>@<version>". Similar to how npm works when adding a package
>> for
>>> the first time, fetching the latest.
>>>
>>>
>>> I am not sure if there is any reason we should not bump the pinning.
>> Since
>>> it is a minor version, I am open to the idea of bumping the pinning.
>>>
>>>
>>> Any objections?
>>>
>>>
>>>
>>> On Tue, Dec 13, 2022 at 6:04 PM julio cesar sanchez <
>> jcesarmobile@gmail.com>
>>> wrote:
>>>
>>>> Shouldn’t we pin cordova-android 11?
>>>> Or that requires a major bump that we don’t want to do at the moment?
>>>>
>>>> But cordova-android 11 is a requirement to publish apps on google play
>>>> since November for existing apps and August for new apps.
>>>>
>>>> El El mar, 13 dic 2022 a las 5:05, Bryan Ellis <er...@apache.org>
>>>> escribió:
>>>>
>>>>> Does anyone have any reason to delay a release for cordova-lib?
>>>>>
>>>>> * cordova-lib (11.1.0)
>>>>>
>>>>> https://github.com/apache/cordova-lib/compare/rel/11.0.0..master <
>>>>> https://github.com/apache/cordova-lib/compare/rel/11.0.0..master>
>>>>>
>>>>> Any additional outstanding changes to land?
>>>>>
>>>>> If not, I will start the release process shortly.
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
>> For additional commands, e-mail: dev-help@cordova.apache.org
>>
>>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org