You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Aravindan Vijayan <av...@hortonworks.com> on 2017/02/07 23:53:56 UTC
Review Request 56416: AMBARI-19908 : Deploy job fails intermittent
due to ambari metrics service check failure
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56416/
-----------------------------------------------------------
Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
Bugs: AMBARI-19908
https://issues.apache.org/jira/browse/AMBARI-19908
Repository: ambari
Description
-------
PROBLEM
Service check for AMS fails intermittently.
BUG
Service check was trying to use certificate file from collector conf dir even though it can be run on any host on the cluster. Hence, file not found exceptions were seen.
FIX
Service check will look for certificate file in Monitor conf dir since monitors are deployed on all hosts.
Grafana script will look for certificate file in Grafana conf dir rather than collector conf (Bug)
Diffs
-----
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py 7e822f2
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana_util.py 65487b7
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/service_check.py 1417f4a
ambari-server/src/test/python/stacks/2.0.6/AMBARI_METRICS/test_metrics_collector.py 6f48eec
ambari-server/src/test/python/stacks/2.0.6/AMBARI_METRICS/test_metrics_grafana.py dc064e4
Diff: https://reviews.apache.org/r/56416/diff/
Testing
-------
Python unit tests pass.
Manually tested.
Thanks,
Aravindan Vijayan
Re: Review Request 56416: AMBARI-19908 : Deploy job fails
intermittent due to ambari metrics service check failure
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56416/#review164591
-----------------------------------------------------------
Fix it, then Ship it!
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py (line 463)
<https://reviews.apache.org/r/56416/#comment236358>
Alias is overridable so should not be hard-set to hostname here. Default setting is ok.
- Sid Wagle
On Feb. 7, 2017, 11:53 p.m., Aravindan Vijayan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56416/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2017, 11:53 p.m.)
>
>
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: AMBARI-19908
> https://issues.apache.org/jira/browse/AMBARI-19908
>
>
> Repository: ambari
>
>
> Description
> -------
>
> PROBLEM
> Service check for AMS fails intermittently.
>
> BUG
> Service check was trying to use certificate file from collector conf dir even though it can be run on any host on the cluster. Hence, file not found exceptions were seen.
>
> FIX
> Service check will look for certificate file in Monitor conf dir since monitors are deployed on all hosts.
> Grafana script will look for certificate file in Grafana conf dir rather than collector conf (Bug)
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py 7e822f2
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana_util.py 65487b7
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/service_check.py 1417f4a
> ambari-server/src/test/python/stacks/2.0.6/AMBARI_METRICS/test_metrics_collector.py 6f48eec
> ambari-server/src/test/python/stacks/2.0.6/AMBARI_METRICS/test_metrics_grafana.py dc064e4
>
> Diff: https://reviews.apache.org/r/56416/diff/
>
>
> Testing
> -------
>
> Python unit tests pass.
> Manually tested.
>
>
> Thanks,
>
> Aravindan Vijayan
>
>
Re: Review Request 56416: AMBARI-19908 : Deploy job fails
intermittent due to ambari metrics service check failure
Posted by Aravindan Vijayan <av...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56416/
-----------------------------------------------------------
(Updated Feb. 8, 2017, 12:03 a.m.)
Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
Bugs: AMBARI-19908
https://issues.apache.org/jira/browse/AMBARI-19908
Repository: ambari
Description
-------
PROBLEM
Service check for AMS fails intermittently.
BUG
Service check was trying to use certificate file from collector conf dir even though it can be run on any host on the cluster. Hence, file not found exceptions were seen.
FIX
Service check will look for certificate file in Monitor conf dir since monitors are deployed on all hosts.
Grafana script will look for certificate file in Grafana conf dir rather than collector conf (Bug)
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/ams.py 7e822f2
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana_util.py 65487b7
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py 0ab6f3a
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/service_check.py 1417f4a
ambari-server/src/test/python/stacks/2.0.6/AMBARI_METRICS/test_metrics_collector.py 6f48eec
ambari-server/src/test/python/stacks/2.0.6/AMBARI_METRICS/test_metrics_grafana.py dc064e4
Diff: https://reviews.apache.org/r/56416/diff/
Testing
-------
Python unit tests pass.
Manually tested.
Thanks,
Aravindan Vijayan