You are viewing a plain text version of this content. The canonical link for it is here.
Posted to proton@qpid.apache.org by Robbie Gemmell <ro...@gmail.com> on 2015/07/08 15:59:14 UTC
Re: Timeline to drop Java 6 support for Proton?
Epic bump.
As per https://issues.apache.org/jira/browse/PROTON-935 the build is
currently broken again on Java 6. We need to either update it to
compile on Java 6, since that is still the builds compiler
source/target, or alternatively drop support for Java 6 and require
Java 7.
I'd do the latter given that noone except the CI box seems to be
testing it, Java 7 is already EOL itself, and most if not all of the
dependent proejcts that I am aware of using proton-j already require
Java 7 themselves now.
Robbie
On 24 September 2014 at 15:24, Robbie Gemmell <ro...@gmail.com> wrote:
> The compilation issue I missed in the patch was test-only this time, but it
> could have as easily been in non-test code. The other tests now failing
> might actually point to some functionality under test not working under Java
> 6 at runtime though, which is more of an issue. If the tests showing it
> didnt exist, or the CI job had been using either the current or previous
> major Java release, then that might not have been noticed prior to release.
>
> Whether it compiles or not isnt the only reason to drop support. Releasing
> new versions that people can continue deploying to EOL plaforms in years to
> come isnt necessarily helping anyone if we aren't in fact properly ensuring
> it really works there. If we dont tuly support it, we should probably cut
> it.
>
> Whether we do it now, or later, I just think it would be a good idea to
> actually decide on a timeline.
>
> Robbie
>
>
> On 24 September 2014 14:11, Clebert Suconic <cs...@redhat.com> wrote:
>>
>> This is just testing... can't you have a java7 tests folder? you would be
>> able to still have java7 specific tests.
>>
>>
>>
>> On Sep 24, 2014, at 7:13 AM, Robbie Gemmell <ro...@gmail.com>
>> wrote:
>>
>> > Hi all,
>> >
>> > With Qpid 0.30 we have made the move to requiring Java 7+. Currently,
>> > proton still allows for use of Java 6, so I wonder what peoples thoughts
>> > are on the timing of a similar move for Proton? I'd personally like to
>> > do
>> > it soon since Java 6 is EOL, but if not then I think we should at least
>> > decide when we will.
>> >
>> > Robbie
>> >
>> > Background:
>> > I committed a patch yesterday which contained some Java 7 API usage in
>> > its
>> > tests, and subsequently broke the ASF Jenkins jobs that are still using
>> > Java 6 (I'm using 8). Having now noticed this I updated the test to make
>> > it
>> > compile and run on Java 6, unfortunately having to disable use of some
>> > of
>> > the input aimed at testing the defect in question. Everything now
>> > compiles
>> > and the test in question passes, but the overall test run is still
>> > failing
>> > because it turns out some other new changes in recent days mean there
>> > are
>> > now a couple of URL tests which fail on Java 6 (but work on Java 8).
>>
>
Re: Timeline to drop Java 6 support for Proton?
Posted by Robbie Gemmell <ro...@gmail.com>.
Ok, I have updated the pom file to use Java 7 for the compiler source
and target, and updated the remaining jobs on the ASF Jenkins CI to
also use Java 7 (having changed the deploy job previously because
Java6 isnt able to work with the recent new SSL proxy).
Currently still failing due the tests though due to issues in the
recent commit from Bozzo.
Robbie
On 8 July 2015 at 16:10, Timothy Bish <ta...@gmail.com> wrote:
> +1 for dropping Java 6 from future releases.
>
> On 07/08/2015 09:59 AM, Robbie Gemmell wrote:
>> Epic bump.
>>
>> As per https://issues.apache.org/jira/browse/PROTON-935 the build is
>> currently broken again on Java 6. We need to either update it to
>> compile on Java 6, since that is still the builds compiler
>> source/target, or alternatively drop support for Java 6 and require
>> Java 7.
>>
>> I'd do the latter given that noone except the CI box seems to be
>> testing it, Java 7 is already EOL itself, and most if not all of the
>> dependent proejcts that I am aware of using proton-j already require
>> Java 7 themselves now.
>>
>> Robbie
>>
>> On 24 September 2014 at 15:24, Robbie Gemmell <ro...@gmail.com> wrote:
>>> The compilation issue I missed in the patch was test-only this time, but it
>>> could have as easily been in non-test code. The other tests now failing
>>> might actually point to some functionality under test not working under Java
>>> 6 at runtime though, which is more of an issue. If the tests showing it
>>> didnt exist, or the CI job had been using either the current or previous
>>> major Java release, then that might not have been noticed prior to release.
>>>
>>> Whether it compiles or not isnt the only reason to drop support. Releasing
>>> new versions that people can continue deploying to EOL plaforms in years to
>>> come isnt necessarily helping anyone if we aren't in fact properly ensuring
>>> it really works there. If we dont tuly support it, we should probably cut
>>> it.
>>>
>>> Whether we do it now, or later, I just think it would be a good idea to
>>> actually decide on a timeline.
>>>
>>> Robbie
>>>
>>>
>>> On 24 September 2014 14:11, Clebert Suconic <cs...@redhat.com> wrote:
>>>> This is just testing... can't you have a java7 tests folder? you would be
>>>> able to still have java7 specific tests.
>>>>
>>>>
>>>>
>>>> On Sep 24, 2014, at 7:13 AM, Robbie Gemmell <ro...@gmail.com>
>>>> wrote:
>>>>
>>>>> Hi all,
>>>>>
>>>>> With Qpid 0.30 we have made the move to requiring Java 7+. Currently,
>>>>> proton still allows for use of Java 6, so I wonder what peoples thoughts
>>>>> are on the timing of a similar move for Proton? I'd personally like to
>>>>> do
>>>>> it soon since Java 6 is EOL, but if not then I think we should at least
>>>>> decide when we will.
>>>>>
>>>>> Robbie
>>>>>
>>>>> Background:
>>>>> I committed a patch yesterday which contained some Java 7 API usage in
>>>>> its
>>>>> tests, and subsequently broke the ASF Jenkins jobs that are still using
>>>>> Java 6 (I'm using 8). Having now noticed this I updated the test to make
>>>>> it
>>>>> compile and run on Java 6, unfortunately having to disable use of some
>>>>> of
>>>>> the input aimed at testing the defect in question. Everything now
>>>>> compiles
>>>>> and the test in question passes, but the overall test run is still
>>>>> failing
>>>>> because it turns out some other new changes in recent days mean there
>>>>> are
>>>>> now a couple of URL tests which fail on Java 6 (but work on Java 8).
>
>
> --
> Tim Bish
> Sr Software Engineer | RedHat Inc.
> tim.bish@redhat.com | www.redhat.com
> twitter: @tabish121
> blog: http://timbish.blogspot.com/
>
Re: Timeline to drop Java 6 support for Proton?
Posted by Timothy Bish <ta...@gmail.com>.
+1 for dropping Java 6 from future releases.
On 07/08/2015 09:59 AM, Robbie Gemmell wrote:
> Epic bump.
>
> As per https://issues.apache.org/jira/browse/PROTON-935 the build is
> currently broken again on Java 6. We need to either update it to
> compile on Java 6, since that is still the builds compiler
> source/target, or alternatively drop support for Java 6 and require
> Java 7.
>
> I'd do the latter given that noone except the CI box seems to be
> testing it, Java 7 is already EOL itself, and most if not all of the
> dependent proejcts that I am aware of using proton-j already require
> Java 7 themselves now.
>
> Robbie
>
> On 24 September 2014 at 15:24, Robbie Gemmell <ro...@gmail.com> wrote:
>> The compilation issue I missed in the patch was test-only this time, but it
>> could have as easily been in non-test code. The other tests now failing
>> might actually point to some functionality under test not working under Java
>> 6 at runtime though, which is more of an issue. If the tests showing it
>> didnt exist, or the CI job had been using either the current or previous
>> major Java release, then that might not have been noticed prior to release.
>>
>> Whether it compiles or not isnt the only reason to drop support. Releasing
>> new versions that people can continue deploying to EOL plaforms in years to
>> come isnt necessarily helping anyone if we aren't in fact properly ensuring
>> it really works there. If we dont tuly support it, we should probably cut
>> it.
>>
>> Whether we do it now, or later, I just think it would be a good idea to
>> actually decide on a timeline.
>>
>> Robbie
>>
>>
>> On 24 September 2014 14:11, Clebert Suconic <cs...@redhat.com> wrote:
>>> This is just testing... can't you have a java7 tests folder? you would be
>>> able to still have java7 specific tests.
>>>
>>>
>>>
>>> On Sep 24, 2014, at 7:13 AM, Robbie Gemmell <ro...@gmail.com>
>>> wrote:
>>>
>>>> Hi all,
>>>>
>>>> With Qpid 0.30 we have made the move to requiring Java 7+. Currently,
>>>> proton still allows for use of Java 6, so I wonder what peoples thoughts
>>>> are on the timing of a similar move for Proton? I'd personally like to
>>>> do
>>>> it soon since Java 6 is EOL, but if not then I think we should at least
>>>> decide when we will.
>>>>
>>>> Robbie
>>>>
>>>> Background:
>>>> I committed a patch yesterday which contained some Java 7 API usage in
>>>> its
>>>> tests, and subsequently broke the ASF Jenkins jobs that are still using
>>>> Java 6 (I'm using 8). Having now noticed this I updated the test to make
>>>> it
>>>> compile and run on Java 6, unfortunately having to disable use of some
>>>> of
>>>> the input aimed at testing the defect in question. Everything now
>>>> compiles
>>>> and the test in question passes, but the overall test run is still
>>>> failing
>>>> because it turns out some other new changes in recent days mean there
>>>> are
>>>> now a couple of URL tests which fail on Java 6 (but work on Java 8).
--
Tim Bish
Sr Software Engineer | RedHat Inc.
tim.bish@redhat.com | www.redhat.com
twitter: @tabish121
blog: http://timbish.blogspot.com/
Re: Timeline to drop Java 6 support for Proton?
Posted by Rafael Schloming <rh...@alum.mit.edu>.
I'm +1 on dropping Java 6.
--Rafael
On Wed, Jul 8, 2015 at 6:59 AM, Robbie Gemmell <ro...@gmail.com>
wrote:
> Epic bump.
>
> As per https://issues.apache.org/jira/browse/PROTON-935 the build is
> currently broken again on Java 6. We need to either update it to
> compile on Java 6, since that is still the builds compiler
> source/target, or alternatively drop support for Java 6 and require
> Java 7.
>
> I'd do the latter given that noone except the CI box seems to be
> testing it, Java 7 is already EOL itself, and most if not all of the
> dependent proejcts that I am aware of using proton-j already require
> Java 7 themselves now.
>
> Robbie
>
> On 24 September 2014 at 15:24, Robbie Gemmell <ro...@gmail.com>
> wrote:
> > The compilation issue I missed in the patch was test-only this time, but
> it
> > could have as easily been in non-test code. The other tests now failing
> > might actually point to some functionality under test not working under
> Java
> > 6 at runtime though, which is more of an issue. If the tests showing it
> > didnt exist, or the CI job had been using either the current or previous
> > major Java release, then that might not have been noticed prior to
> release.
> >
> > Whether it compiles or not isnt the only reason to drop support.
> Releasing
> > new versions that people can continue deploying to EOL plaforms in years
> to
> > come isnt necessarily helping anyone if we aren't in fact properly
> ensuring
> > it really works there. If we dont tuly support it, we should probably cut
> > it.
> >
> > Whether we do it now, or later, I just think it would be a good idea to
> > actually decide on a timeline.
> >
> > Robbie
> >
> >
> > On 24 September 2014 14:11, Clebert Suconic <cs...@redhat.com> wrote:
> >>
> >> This is just testing... can't you have a java7 tests folder? you would
> be
> >> able to still have java7 specific tests.
> >>
> >>
> >>
> >> On Sep 24, 2014, at 7:13 AM, Robbie Gemmell <ro...@gmail.com>
> >> wrote:
> >>
> >> > Hi all,
> >> >
> >> > With Qpid 0.30 we have made the move to requiring Java 7+. Currently,
> >> > proton still allows for use of Java 6, so I wonder what peoples
> thoughts
> >> > are on the timing of a similar move for Proton? I'd personally like to
> >> > do
> >> > it soon since Java 6 is EOL, but if not then I think we should at
> least
> >> > decide when we will.
> >> >
> >> > Robbie
> >> >
> >> > Background:
> >> > I committed a patch yesterday which contained some Java 7 API usage in
> >> > its
> >> > tests, and subsequently broke the ASF Jenkins jobs that are still
> using
> >> > Java 6 (I'm using 8). Having now noticed this I updated the test to
> make
> >> > it
> >> > compile and run on Java 6, unfortunately having to disable use of some
> >> > of
> >> > the input aimed at testing the defect in question. Everything now
> >> > compiles
> >> > and the test in question passes, but the overall test run is still
> >> > failing
> >> > because it turns out some other new changes in recent days mean there
> >> > are
> >> > now a couple of URL tests which fail on Java 6 (but work on Java 8).
> >>
> >
>