You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/12/14 19:37:58 UTC

[GitHub] [geode] upthewaterspout commented on a change in pull request #5840: GEODE-8782: Add getPrincipal method to FunctionContext interface

upthewaterspout commented on a change in pull request #5840:
URL: https://github.com/apache/geode/pull/5840#discussion_r542691265



##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/execute/FunctionRemoteContext.java
##########
@@ -84,6 +85,10 @@ public void fromData(DataInput in) throws IOException, ClassNotFoundException {
       this.bucketArray = BucketSetHelper.fromSet(bucketSet);
     }
     this.isReExecute = DataSerializer.readBoolean(in);
+
+    if (StaticSerialization.getVersionForDataStream(in).isNotOlderThan(KnownVersion.GEODE_1_14_0)) {

Review comment:
       Instead of this, I think you could make this class implement VersionedDataSerializable which might handle writing the principal differently.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org