You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/06/30 07:46:39 UTC

[GitHub] pengzhao-intel commented on a change in pull request #11498: Fix InferStorage for sparse fallback in FullyConnected

pengzhao-intel commented on a change in pull request #11498: Fix InferStorage for sparse fallback in FullyConnected
URL: https://github.com/apache/incubator-mxnet/pull/11498#discussion_r199316240
 
 

 ##########
 File path: src/operator/nn/fully_connected.cc
 ##########
 @@ -210,17 +210,17 @@ inline static bool BackwardFCStorageType(const nnvm::NodeAttrs& attrs,
   CHECK_EQ(in_attrs->size(), 3U);
   CHECK_EQ(out_attrs->size(), out_expected);
 
-  DispatchMode wanted_mode;
-#if 0
+  bool dispatched = false;
   // TODO(zhengda) let's disable MKLDNN for FullyConnected for now.
 
 Review comment:
   We have enabled this in the #11301 and it passed all unit tests and coverage test in our local.
   So, I think MKLDNN FC backward works fine.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services