[GitHub] [buildstream] abderrahim commented on a diff in pull request #1632: tests: xfail integration tests that fail without buildbox-fuse

[GitBox <gi...@apache.org>]

abderrahim commented on code in PR #1632:
URL: https://github.com/apache/buildstream/pull/1632#discussion_r846583569


##########
tests/integration/script.py:
##########
@@ -171,6 +172,7 @@ def test_script_layout(cli, datafiles):
     HAVE_SANDBOX == "buildbox-run" and BUILDBOX_RUN == "buildbox-run-userchroot",
     reason="Root directory not writable with userchroot",
 )
+@pytest.mark.xfail(not HAVE_BUILDBOX_FUSE, reason="Root directory not writable without buildbox-fuse")

Review Comment:
   Thinking about this, I think it's an expected failure without buildbox-fuse. I don't know much about userchroot, but I don't think it's related: if we have a the fuse layer to protect the underlying blobs from corruption we can allow their modification. If not we'll simply protect them by not allowing writing (of course, this will only protect from accidental modification and you need to run buildbox-casd as a different user to protect against malicious modification).
   
   I think the relationship between buildbox-fuse and buildbox-run-userchroot is a correlation (if you're using userchroot you're likely not on linux so you can't use fuse) rather than a strict relation.
   
   Did I miss something?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org