You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/06/12 13:52:53 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6412: drivers/sensors: add driver for as5048a magnetic encoder
xiaoxiang781216 commented on code in PR #6412:
URL: https://github.com/apache/incubator-nuttx/pull/6412#discussion_r895178463
##########
include/nuttx/sensors/as5048a.h:
##########
@@ -0,0 +1,146 @@
+/****************************************************************************
+ * include/nuttx/sensors/as5048a.h
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+#ifndef __INCLUDE_NUTTX_SENSORS_AS5048A
+#define __INCLUDE_NUTTX_SENSORS_AS5048A
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/config.h>
+#include <nuttx/fs/ioctl.h>
+#include <nuttx/spi/spi.h>
+#include <nuttx/sensors/qencoder.h>
+
+#if defined(CONFIG_SPI) && defined(CONFIG_SENSORS_QENCODER) && defined(CONFIG_SENSORS_AS5048A)
Review Comment:
it's enough to check CONFIG_SENSORS_AS5048A
##########
drivers/sensors/as5048a.c:
##########
@@ -0,0 +1,632 @@
+/****************************************************************************
+ * drivers/sensors/as5048a.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/config.h>
+
+#include <assert.h>
+#include <errno.h>
+#include <debug.h>
+#include <stdlib.h>
+
+#include <nuttx/kmalloc.h>
+#include <nuttx/fs/fs.h>
+#include <nuttx/spi/spi.h>
+#include <nuttx/sensors/as5048a.h>
+
+#if defined(CONFIG_SPI) && defined(CONFIG_SENSORS_QENCODER) && defined(CONFIG_SENSORS_AS5048A)
Review Comment:
let's only check CONFIG_SENSORS_AS5048A or remove all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org