[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5295: sim: Added Kconfig option for UART buffer size.

[GitBox <gi...@apache.org>]

pkarashchenko commented on a change in pull request #5295:
URL: https://github.com/apache/incubator-nuttx/pull/5295#discussion_r790315067



##########
File path: arch/sim/src/sim/up_uart.c
##########
@@ -31,12 +31,16 @@
 
 #include "up_internal.h"
 
-#if defined(USE_DEVCONSOLE) || CONFIG_SIM_UART_NUMBER > 0
+#if defined(USE_DEVCONSOLE) || defined(CONFIG_SIM_UART)
 /****************************************************************************
  * Pre-processor Definitions
  ****************************************************************************/
 
-#define BUFSIZE 256
+#ifdef CONFIG_SIM_UART_BUFFER_SIZE

Review comment:
       Just as an alternative we can replace `BUFSIZE` with `CONFIG_SIM_UART_BUFFER_SIZE` and have here
   ```
   #ifndef CONFIG_SIM_UART_BUFFER_SIZE
   #  define CONFIG_SIM_UART_BUFFER_SIZE 256
   #endif
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org