You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/02/02 00:37:11 UTC

[GitHub] [skywalking] BFergerson commented on pull request #6183: Add a new concept "Event" and its implementations to collect events

BFergerson commented on pull request #6183:
URL: https://github.com/apache/skywalking/pull/6183#issuecomment-771260649


   I gave this a look and try. The only things I've noticed that seem problematic is that `uuid` is not guaranteed to be unique. You can re-use the same `uuid` and the event system will accept it. Also, the `queryEvents` endpoint allows you to not define the start/end/step. I don't think other endpoints allow you not to specify the time range. Seems like it should be required.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org