[jira] [Comment Edited] (YARN-9360) Do not expose innards of QueueMetrics object into FSLeafQueue#computeMaxAMResource

["Szilard Nemeth (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16884931#comment-16884931 ] 

Szilard Nemeth edited comment on YARN-9360 at 7/15/19 8:49 AM:
---------------------------------------------------------------

HI [~pbacsko]!
+1 for the latest patch, committing this soon to trunk. Just trunk, as this patch is a follow-up for YARN-9323 and that patch is not backported to 3.2 / 3.1 so we neither do need to backport this one.


was (Author: snemeth):
HI [~pbacsko]!
+1 for the latest patch, committing this soon!

> Do not expose innards of QueueMetrics object into FSLeafQueue#computeMaxAMResource
> ----------------------------------------------------------------------------------
>
>                 Key: YARN-9360
>                 URL: https://issues.apache.org/jira/browse/YARN-9360
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Szilard Nemeth
>            Assignee: Peter Bacsko
>            Priority: Major
>         Attachments: YARN-9360.001.patch, YARN-9360.002.patch, YARN-9360.003.patch, YARN-9360.003.patch
>
>
> This is a follow-up for YARN-9323, covering required changes as discussed with [~templedf] earlier.
> After YARN-9323, org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FSLeafQueue#computeMaxAMResource gets the QueueMetricsForCustomResources object from scheduler.getRootQueueMetrics().
> Instead, we should use a "fill-in" method in QueueMetrics that receives a Resource and fills in custom resource values if they are non-zero.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org