[jira] [Commented] (KYLIN-4063) Avoid repeatedly calling "string.toLowerCase" in TimedJsonStreamParser#parse

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KYLIN-4063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16878604#comment-16878604 ] 

ASF GitHub Bot commented on KYLIN-4063:
---------------------------------------

zhangayqian commented on pull request #733: KYLIN-4063 Avoid repeatedly calling "string.toLowerCase" in TimedJson…
URL: https://github.com/apache/kylin/pull/733
 
 
   …StreamParser#parse
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Avoid repeatedly calling "string.toLowerCase" in TimedJsonStreamParser#parse
> ----------------------------------------------------------------------------
>
>                 Key: KYLIN-4063
>                 URL: https://issues.apache.org/jira/browse/KYLIN-4063
>             Project: Kylin
>          Issue Type: Improvement
>          Components: NRT Streaming
>            Reporter: Shaofeng SHI
>            Assignee: Yaqian Zhang
>            Priority: Major
>
> In TimedJsonStreamParser#parse, it has this:
>  
> {code:java}
> for (TblColRef column : allColumns) {
>     final String columnName = column.getName().toLowerCase(Locale.ROOT);
>     if (populateDerivedTimeColumns(columnName, result, t) == false) {
>         result.add(getValueByKey(column, root));
>     }
> }
> {code}
>  
> As this method will be invoked for each message, and then for each column it will have a "toLowerCase(Locale.ROOT)", which is unnecessary, because the "allColumns" won't change.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)