You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/10/27 15:47:54 UTC
[GitHub] [iceberg] marton-bod opened a new pull request #1670: Build standalone jar for hive3 module
marton-bod opened a new pull request #1670:
URL: https://github.com/apache/iceberg/pull/1670
Currently Hive engine-related Iceberg classes are split between `iceberg-mr` and `iceberg-hive3`. This makes it difficult and potentially confusing for clients to pull them in as a dependency. For example, if a client uses Hive3, they would - a bit counterintuitively - need to pull in both jars instead of just the `hive3` jar, since `mr` does not contain the hive3-compatible object inspector classes and `hive3` only contains those and nothing else.
To solve that, we should build the `mr` main source files as well with Hive3 dependencies in the `hive3` module, and just exclude those couple of object inspectors that rely on Hive2 classes. This ensures that in the end we get a nice standalone `hive3` jar that clients can readily use.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #1670: Build standalone jar for hive3 module
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #1670:
URL: https://github.com/apache/iceberg/pull/1670#issuecomment-717402821
Can you help me understand why this is needed? The iceberg-hive3 module depends on iceberg-mr, so anyone that adds a dependency on iceberg-hive3 should pull in the other module transitively. That seems fine to me without building anything additional into the Hive 3 module.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] marton-bod commented on pull request #1670: Build standalone jar for hive3 module
Posted by GitBox <gi...@apache.org>.
marton-bod commented on pull request #1670:
URL: https://github.com/apache/iceberg/pull/1670#issuecomment-717466809
@rdblue yes, you're right. This was some premature optimization on my part, without thinking it through well enough. Closing this PR. Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] marton-bod closed pull request #1670: Build standalone jar for hive3 module
Posted by GitBox <gi...@apache.org>.
marton-bod closed pull request #1670:
URL: https://github.com/apache/iceberg/pull/1670
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org