You are viewing a plain text version of this content. The canonical link for it is here.
Posted to user@commons.apache.org by "Mike Sparr - www.goomzee.com" <mi...@goomzee.com> on 2005/12/14 20:34:43 UTC

RE: [SCXML] Send

Hi Rahul,

I agree to think about getBodyContent.  Perhaps just best to interate
and populate StringBuffer and return String of contents, without DOM,
XMLSerialize, Element (and Xerces, etc dependencies).  This way we can
choose how we parse/handle the contents.  As long as it's well-formed,
spacing/formatting shouldn't matter, perhaps just add the "\n" and
that's it?

===

I believe the EventDispatcher#send needs to have externalNodes added,
and if you decide to add the getBodyContent, then perhaps a String
bodyContent (not sure about that)?  Do you allow method overloading in
your Interfaces?

====

public interface EventDispatcher {

    /**
     * Cancel the specified send message.
     *
     * @param sendId The ID of the send message to cancel
     */
    void cancel(String sendId);

    /**
     * Send this message to the target.
     *
     * @param sendId The ID of the send message
     * @param target An expression returning the target location of the
event
     * @param targetType The type of the Event I/O Processor that the
event
     *  should be dispatched to
     * @param event The type of event being generated.
     * @param params A list of zero or more whitespace separated
variable
     *  names to be included with the event.
     * @param hints The data containing information which may be
     *  used by the implementing platform to configure the event
processor
     * @param delay The event is dispatched after the delay interval
elapses
     */
    void send(String sendId, String target, String targetType,
            String event, Map params, Object hints, long delay);

}

====

Should the send method be (or just add these [overload])?:

    void send(String sendId, String target, String targetType,
            String event, Map params, Object hints, long delay, 
            List externalNodes);

    void send(String sendId, String target, String targetType,
            String event, Map params, Object hints, long delay, 
            List externalNodes, String bodyContent);


/Mike





-----Original Message-----
From: Rahul Akolkar [mailto:rahul.akolkar@gmail.com] 
Sent: Tuesday, December 13, 2005 12:44 PM
To: Jakarta Commons Users List; mike@goomzee.com
Subject: Re: [SCXML] Concurrent users


On 12/13/05, Mike Sparr - www.goomzee.com <mi...@goomzee.com> wrote:
> Rahul,
>
> I think build may have broke due to dependency on XercesImpl, 
> xml-apis, and possibly xalan jar dependencies.  Your recent code 
> change likely requires them now so you may update the dependencies and

> jars to your build.xml, plus the docs.
<snip/>

Yes, I revisited this yesterday. At this point, I'm not happy declaring
those dependencies, so I left a comment in the code and removed the
recently added utility method Send#getBodyContent(). The details of the
related change are here:

http://svn.apache.org/viewcvs.cgi?rev=356390&view=rev

It seems the Commons nightlies didn't build today (none of the projects
were built) so today's failure seems unrelated.


>  Also, we noticed that the context vars return
> null within onentry and can only be retrieved during ontransition.  
> I'm not sure if just our implementation or how it's built.  Anyhow, 
> just a little input from our findings.
>
<snap/>

Umm, that doesn't sound right. If you can produce the smallest possible
test document that demonstrates this, I'll be happy to take a look.

-Rahul


> Rgds,
>
> Mike
>
<snip/>

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-user-help@jakarta.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-user-help@jakarta.apache.org


Re: [SCXML] Send

Posted by Rahul Akolkar <ra...@gmail.com>.
On 12/14/05, Mike Sparr - www.goomzee.com <mi...@goomzee.com> wrote:
> Hi Rahul,
>
<snip/>
>
> I believe the EventDispatcher#send needs to have externalNodes added,
> and if you decide to add the getBodyContent, then perhaps a String
> bodyContent (not sure about that)?  Do you allow method overloading in
> your Interfaces?
>
<snap/>
>
> Should the send method be (or just add these [overload])?:
>
>    void send(String sendId, String target, String targetType,
>            String event, Map params, Object hints, long delay,
>            List externalNodes);
>
<snip/>

Yes, thats what it should be, thanks. Will make the change in a minute.



>    void send(String sendId, String target, String targetType,
>            String event, Map params, Object hints, long delay,
>            List externalNodes, String bodyContent);
>
<snap/>

This, however, is mostly redundant. The users are free to do what they
need with the externalNodes (i.e. they can serialize those, if thats
what suits the particular task at hand -- which is probably what you
need to do for your purposes).

-Rahul


>
> /Mike
>

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-user-help@jakarta.apache.org