[GitHub] [httpcomponents-core] carterkozak commented on a change in pull request #199: HTTPCORE-636: Logging statements use slf4j interpolation over concatenation

[GitBox <gi...@apache.org>]

carterkozak commented on a change in pull request #199:
URL: https://github.com/apache/httpcomponents-core/pull/199#discussion_r449234336



##########
File path: httpcore5-testing/src/main/java/org/apache/hc/core5/testing/nio/LoggingIOSession.java
##########
@@ -76,7 +76,7 @@ public Lock getLock() {
     public void enqueue(final Command command, final Command.Priority priority) {
         this.session.enqueue(command, priority);
         if (this.log.isDebugEnabled()) {
-            this.log.debug(this.session + " Enqueued " + command.getClass().getSimpleName() + " with priority " + priority);
+            this.log.debug("{} Enqueued {} with priority {}", this.session, command.getClass().getSimpleName(), priority);

Review comment:
       That's true, I've updated these.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org