You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/06/30 12:50:34 UTC
[GitHub] [inlong] Greedyu opened a new pull request, #4825: [INLONG-4824][Agent] Add line numbers to Agent module log output
Greedyu opened a new pull request, #4825:
URL: https://github.com/apache/inlong/pull/4825
Add line numbers to Agent module log output
- Fixes #4824
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #4825: [INLONG-4824][Agent] Print line numbers in log info
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #4825:
URL: https://github.com/apache/inlong/pull/4825#discussion_r911183793
##########
inlong-agent/conf/log4j2.xml:
##########
@@ -20,7 +20,7 @@
<configuration status="WARN" monitorInterval="30">
<Properties>
<property name="basePath">${sys:agent.home}/logs</property>
- <property name="log_pattern">%d{yyyy-MM-dd HH:mm:ss.SSS} -%5p ${PID:-} [%15.15t] %-30.30C{1.} : %m%n</property>
+ <property name="log_pattern">%d{yyyy-MM-dd HH:mm:ss.SSS} -%5p ${PID:-} [%15.15t] %-30.30C{1.}:%L %m%n</property>
Review Comment:
Are there any other log configurations of the agent module that need to be modified?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] Greedyu commented on a diff in pull request #4825: [INLONG-4824][Agent] Print line numbers in log info
Posted by GitBox <gi...@apache.org>.
Greedyu commented on code in PR #4825:
URL: https://github.com/apache/inlong/pull/4825#discussion_r911574275
##########
inlong-agent/conf/log4j2.xml:
##########
@@ -20,7 +20,7 @@
<configuration status="WARN" monitorInterval="30">
<Properties>
<property name="basePath">${sys:agent.home}/logs</property>
- <property name="log_pattern">%d{yyyy-MM-dd HH:mm:ss.SSS} -%5p ${PID:-} [%15.15t] %-30.30C{1.} : %m%n</property>
+ <property name="log_pattern">%d{yyyy-MM-dd HH:mm:ss.SSS} -%5p ${PID:-} [%15.15t] %-30.30C{1.}:%L %m%n</property>
Review Comment:
The agent module is not adjusted first, and the logs that other modules do not print line numbers are changed
<img width="667" alt="wecom-temp-b576ae7825a12152918685d5fa3d7d8b" src="https://user-images.githubusercontent.com/20356765/176813628-231daad6-f043-4f39-b4eb-4b18e96521d7.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] Greedyu commented on pull request #4825: [INLONG-4824][Agent] Print line numbers in log info
Posted by GitBox <gi...@apache.org>.
Greedyu commented on PR #4825:
URL: https://github.com/apache/inlong/pull/4825#issuecomment-1171869758
> configurations
resolve
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang commented on pull request #4825: [INLONG-4824][Agent] Print line numbers in log info
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on PR #4825:
URL: https://github.com/apache/inlong/pull/4825#issuecomment-1171855311
@Greedyu please check the log4j configurations for the `DataProxy` and `Manager` at the same time, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang merged pull request #4825: [INLONG-4824][Log] Print line numbers in log info for all modules
Posted by GitBox <gi...@apache.org>.
dockerzhang merged PR #4825:
URL: https://github.com/apache/inlong/pull/4825
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org