You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by de...@apache.org on 2016/10/17 18:21:41 UTC

svn commit: r1765347 - in /ofbiz/trunk/applications/accounting: minilang/ledger/GeneralLedgerServices.xml servicedef/services_ledger.xml

Author: deepak
Date: Mon Oct 17 18:21:41 2016
New Revision: 1765347

URL: http://svn.apache.org/viewvc?rev=1765347&view=rev
Log:
Improved: Convert GlAccountOrganization entity related CRUD services from simple to entity-auto.
(OFBIZ-8379)(OFBIZ-8380)

Thanks Pawan Verma for your contribution.

Modified:
    ofbiz/trunk/applications/accounting/minilang/ledger/GeneralLedgerServices.xml
    ofbiz/trunk/applications/accounting/servicedef/services_ledger.xml

Modified: ofbiz/trunk/applications/accounting/minilang/ledger/GeneralLedgerServices.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/minilang/ledger/GeneralLedgerServices.xml?rev=1765347&r1=1765346&r2=1765347&view=diff
==============================================================================
--- ofbiz/trunk/applications/accounting/minilang/ledger/GeneralLedgerServices.xml (original)
+++ ofbiz/trunk/applications/accounting/minilang/ledger/GeneralLedgerServices.xml Mon Oct 17 18:21:41 2016
@@ -51,32 +51,6 @@ under the License.
         <remove-value value-field="lookedUpValue"/>
     </simple-method>
 
-    <!-- ========= GlAccountOrganization methods ========= -->
-    <simple-method method-name="createGlAccountOrganization" short-description="Create GlAccountOrganization">
-        <make-value entity-name="GlAccountOrganization" value-field="newEntity"/>
-        <if-empty field="parameters.fromDate">
-            <now-timestamp field="parameters.fromDate"/>
-        </if-empty>
-        <set-nonpk-fields map="parameters" value-field="newEntity"/>
-        <set-pk-fields map="parameters" value-field="newEntity"/>
-
-        <create-value value-field="newEntity"/>
-    </simple-method>
-    <simple-method method-name="updateGlAccountOrganization" short-description="Update GlAccountOrganization">
-        <make-value entity-name="GlAccountOrganization" value-field="lookupPKMap"/>
-        <set-pk-fields map="parameters" value-field="lookupPKMap"/>
-        <find-by-primary-key map="lookupPKMap" value-field="lookedUpValue"/>
-        <set-nonpk-fields map="parameters" value-field="lookedUpValue"/>
-
-        <store-value value-field="lookedUpValue"/>
-    </simple-method>
-    <simple-method method-name="deleteGlAccountOrganization" short-description="Delete GlAccountOrganization">
-        <make-value entity-name="GlAccountOrganization" value-field="lookupPKMap"/>
-        <set-pk-fields map="parameters" value-field="lookupPKMap"/>
-        <find-by-primary-key map="lookupPKMap" value-field="lookedUpValue"/>
-        <remove-value value-field="lookedUpValue"/>
-    </simple-method>
-
     <!-- ========= GlJournal methods ========= -->
     <simple-method method-name="quickCreateAcctgTransAndEntries" short-description="Creates an AcctgTrans and two offsetting AcctgTransEntry records">
         <!-- TODO: Do we need to create a GlJournal record here? -->

Modified: ofbiz/trunk/applications/accounting/servicedef/services_ledger.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/servicedef/services_ledger.xml?rev=1765347&r1=1765346&r2=1765347&view=diff
==============================================================================
--- ofbiz/trunk/applications/accounting/servicedef/services_ledger.xml (original)
+++ ofbiz/trunk/applications/accounting/servicedef/services_ledger.xml Mon Oct 17 18:21:41 2016
@@ -52,22 +52,19 @@ under the License.
         <auto-attributes include="pk" mode="IN" optional="false"/>
     </service>
 
-    <service name="createGlAccountOrganization" default-entity-name="GlAccountOrganization" engine="simple"
-            location="component://accounting/minilang/ledger/GeneralLedgerServices.xml" invoke="createGlAccountOrganization" auth="true">
+    <service name="createGlAccountOrganization" default-entity-name="GlAccountOrganization" engine="entity-auto" invoke="create" auth="true">
         <description>Create a GlAccount record</description>
         <permission-service service-name="basicGeneralLedgerPermissionCheck" main-action="CREATE"/>
         <auto-attributes include="pk" mode="IN" optional="false"/>
         <auto-attributes include="nonpk" mode="IN" optional="true"/>
     </service>
-    <service name="updateGlAccountOrganization" default-entity-name="GlAccountOrganization" engine="simple"
-            location="component://accounting/minilang/ledger/GeneralLedgerServices.xml" invoke="updateGlAccountOrganization" auth="true">
+    <service name="updateGlAccountOrganization" default-entity-name="GlAccountOrganization" engine="entity-auto" invoke="update" auth="true">
         <description>Update a GlAccount record</description>
         <permission-service service-name="basicGeneralLedgerPermissionCheck" main-action="UPDATE"/>
         <auto-attributes include="pk" mode="IN" optional="false"/>
         <auto-attributes include="nonpk" mode="IN" optional="true"/>
     </service>
-    <service name="deleteGlAccountOrganization" default-entity-name="GlAccountOrganization" engine="simple"
-            location="component://accounting/minilang/ledger/GeneralLedgerServices.xml" invoke="deleteGlAccountOrganization" auth="true">
+    <service name="deleteGlAccountOrganization" default-entity-name="GlAccountOrganization" engine="entity-auto" invoke="delete" auth="true">
         <description>Delete a GlAccount record</description>
         <permission-service service-name="basicGeneralLedgerPermissionCheck" main-action="DELETE"/>
         <auto-attributes include="pk" mode="IN" optional="false"/>