[GitHub] [kafka] satishd commented on a diff in pull request #13013: KAFKA-14466 Move ClassloaderAwareRemoteStorageManager to storage module

[GitBox <gi...@apache.org>]

satishd commented on code in PR #13013:
URL: https://github.com/apache/kafka/pull/13013#discussion_r1051962413


##########
storage/src/main/java/org/apache/kafka/server/log/remote/storage/ClassLoaderAction.java:
##########
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.server.log.remote.storage;
+
+/**
+ * This interface is used to execute any remote storage/metadata related operation.
+ *
+ * @param <T> return type for execute operation
+ * @param <E> Exception type to be thrown
+ */
+@FunctionalInterface
+public interface ClassLoaderAction<T, E extends Exception> {

Review Comment:
   I set the name as `RemoteStorageAction` as it was meant for any remote storage actions. I though you wanted this to be classloader specific in your earlier comment. I am fine with renaming it to `StorageAction` so that it can be reused for any storage specific operations. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org