You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by duncangrant <gi...@git.apache.org> on 2016/10/05 21:11:44 UTC
[GitHub] brooklyn-server pull request #371: One instance of customizer at each custom...
GitHub user duncangrant opened a pull request:
https://github.com/apache/brooklyn-server/pull/371
One instance of customizer at each customize step
Change so that getCustomizers is only called once during provisioning.
This ensures that only a single instance of a customizer configured
with DSL will be called. This means that state can be kept between
steps.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/duncangrant/brooklyn-server fix-customizers-with-config
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/371.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #371
----
commit 071537c9ddd2959252c9ea3dc2647620e7299ef0
Author: Duncan Grant <du...@cloudsoftcorp.com>
Date: 2016-10-04T15:26:29Z
One instance of customizer at each customize step
Change so that getCustomizers is only called once during provisioning.
This ensures that only a single instance of a customizer configured
with DSL will be called. This means that state can be kept between
steps.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #371: One instance of customizer at each customize ste...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/371
LGTM; once jenkins has confirmed the tests pass, this is good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request #371: One instance of customizer at each custom...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/371
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server issue #371: One instance of customizer at each customize ste...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/371
LGTM; I've submitted https://github.com/duncangrant/brooklyn-server/pull/1 to add some additional changes in this PR.
@duncangrant can you review that - if you merge it into your branch, then it will appear automatically in this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request #371: One instance of customizer at each custom...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/371#discussion_r82154264
--- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java ---
@@ -409,7 +409,7 @@ protected CloudMachineNamer getCloudMachineNamer(ConfigBag config) {
}
}
- protected Collection<JcloudsLocationCustomizer> getCustomizers(ConfigBag setup) {
+ public Collection<JcloudsLocationCustomizer> getCustomizers(ConfigBag setup) {
--- End diff --
I'm slightly uncomfortable about this becoming public - but I see why you had to do it, to let it be called by `CloudExplorerSupport.java`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---