[GitHub] [dolphinscheduler] ruanwenjun commented on a diff in pull request #11206: [Improvement][Worker] Resource may store in hadoop/S3

[GitBox <gi...@apache.org>]

ruanwenjun commented on code in PR #11206:
URL: https://github.com/apache/dolphinscheduler/pull/11206#discussion_r933344189


##########
dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/TaskExecutionContext.java:
##########
@@ -218,7 +218,8 @@ public class TaskExecutionContext implements Serializable {
     private ExecutionStatus currentExecutionStatus;
 
     /**
-     *  Task Logger name should be like: Task-{processDefinitionId}-{processInstanceId}-{taskInstanceId}
+     * Task Logger name should be like:
+     * TaskAppId=TASK-{firstSubmitTime}-{processDefineCode}_{processDefineVersion}-{processInstanceId}-{taskInstanceId}

Review Comment:
   Why did we need to add `TaskAppId=` in the prefix? 
   I think the `TASK-{firstSubmitTime}-{processDefineCode}_{processDefineVersion}-{processInstanceId}-{taskInstanceId}` is enough
   cc @caishunfeng 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org