You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "alex-kar (via GitHub)" <gi...@apache.org> on 2024/09/27 01:49:19 UTC
[PR] Config File Handling [iceberg-go]
alex-kar opened a new pull request, #156:
URL: https://github.com/apache/iceberg-go/pull/156
Handle config file `.iceberg-go.yaml` in the home directory.
Closes #62
@zeroshade I noticed that `--catalog` has different functionality compare to pyiceberg cli, where it defines catalog name to be loaded from configuration file.
iceberg-go - `--catalog` - catalog type.
pyiceberg `--catalog` - catalog name to load from configuration file.
Because of this reason, currently it can load only `default` catalog.
Another note is that `docopt` throw's exception when struct has some non default values.
https://github.com/docopt/docopt.go/issues/55
Because of this limitation, I can't first parse configuration file and then provide the same struct to `docopt` to ensure the correct precedence. instead I added this manual mapping:
```
func mergeConf(fileConf *config.CatalogConfig, resConfig *Config) {
if len(resConfig.Catalog) == 0 {
resConfig.Catalog = fileConf.Catalog
}
...
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Config File Handling [iceberg-go]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on PR #156:
URL: https://github.com/apache/iceberg-go/pull/156#issuecomment-2418645089
@alex-kar can you please rebase and fix the merge conflict?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Config File Handling [iceberg-go]
Posted by "alex-kar (via GitHub)" <gi...@apache.org>.
alex-kar commented on PR #156:
URL: https://github.com/apache/iceberg-go/pull/156#issuecomment-2419117570
@nastra Rebased onto the latest `main`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Config File Handling [iceberg-go]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra merged PR #156:
URL: https://github.com/apache/iceberg-go/pull/156
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org